Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2140603003: Revert of Add HardStopGradientBench.cpp (Closed)

Created:
4 years, 5 months ago by fmenozzi
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add HardStopGradientBench.cpp (patchset #3 id:40001 of https://codereview.chromium.org/2131643002/ ) Reason for revert: Segfaulting on HardStopGradientBench; didn't allocate enough stack memory for color/position arrays. Original issue's description: > Add HardStopGradientBench.cpp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131643002 > > Committed: https://skia.googlesource.com/skia/+/d0d652e0e0cb4bcecb7ccac9f4f4831fcaccdc45 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ffa185d3cf80f1dca1f1e4efc2737df9eb552bdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -118 lines) Patch
D bench/HardStopGradientBench.cpp View 1 chunk +0 lines, -118 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
fmenozzi
Created Revert of Add HardStopGradientBench.cpp
4 years, 5 months ago (2016-07-11 16:30:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140603003/1
4 years, 5 months ago (2016-07-11 16:30:21 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 16:30:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ffa185d3cf80f1dca1f1e4efc2737df9eb552bdf

Powered by Google App Engine
This is Rietveld 408576698