[telemetry] Refactoring of telemetry for the webdriver backend to land in.

[telemetry] Refactoring of telemetry for the webdriver backend to land in.

1. Create telemetry.core.backends.browser_backend that can be shared by both chrome and webdriver.
2. Move telemetry.core.chrome.browser_backend to telemetry.core.backends.chrome.chrome_browser_backend.
3. Move DoNothingForwarder to telemetry.core.backends.browser_backend.
4. Add CreatePlatformBackendForCurrentOS to telemetry/core/platform/__init__.py
5. Add a hook browser_backend.AddReplayServerOptions.
6. Override webpagereplay.ReplayServer._AddDefaultReplayOptions because '--no-dns_forwarding' is added by default in webpagereplay.ReplayServer while webdriver-based backends need dns forwarding.

BUG=267219
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215340

[chrisgao (Use stgao instead), 2013-07-31 23:53:51]

https://codereview.chromium.org/21406004/diff/1/tools/telemetry/telemetry/cor...
File tools/telemetry/telemetry/core/chrome/browser_backend.py (right):

https://codereview.chromium.org/21406004/diff/1/tools/telemetry/telemetry/cor...
tools/telemetry/telemetry/core/chrome/browser_backend.py:2: # Use of this source
code is governed by a BSD-style license that can be
This should be a delete instead of a modify.

[chrisgao (Use stgao instead), 2013-08-01 00:01:46]

The first patch was from https://codereview.chromium.org/20672002/.


I separate stuff withOUT regard to webdriver backend into this CL from 20672002.

[dtu, 2013-08-01 00:14:13]

Sorry, I meant that both core/chrome/ and core/webdriver/ should now go in
core/backends/ as core/backends/chrome/ and core/backends/webdriver/

[dtu, 2013-08-01 21:23:27]

lgtm with nits

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/core/backends/browser_backend.py (right):

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
tools/telemetry/telemetry/core/backends/browser_backend.py:26: def
CustomizeReplayServerWithOptions(self, options):
nit: AddReplayServerOptions

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/core/util.py (right):

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
tools/telemetry/telemetry/core/util.py:73: class DoNothingForwarder(object):
Can you keep this in BrowserBackend? I don't want util to slowly become the
"junk drawer" of Telemetry.

[chrisgao (Use stgao instead), 2013-08-02 01:00:12]

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/core/backends/browser_backend.py (right):

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
tools/telemetry/telemetry/core/backends/browser_backend.py:26: def
CustomizeReplayServerWithOptions(self, options):
On 2013/08/01 21:23:27, Dave Tu wrote:
> nit: AddReplayServerOptions

Done.

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
File tools/telemetry/telemetry/core/util.py (right):

https://codereview.chromium.org/21406004/diff/21001/tools/telemetry/telemetry...
tools/telemetry/telemetry/core/util.py:73: class DoNothingForwarder(object):
On 2013/08/01 21:23:27, Dave Tu wrote:
> Can you keep this in BrowserBackend? I don't want util to slowly become the
> "junk drawer" of Telemetry.

Done, moved to telemetry/core/backends/browser_backend.py

[achuithb, 2013-08-02 01:07:12]

It would be great if you could file a bug for this work item, since it's pretty
big.

[chrisgao (Use stgao instead), 2013-08-02 01:23:40]

Thanks for the suggestion!
crbug.com/267219 was created.


On Thu, Aug 1, 2013 at 6:07 PM, <achuith@chromium.org> wrote:

> It would be great if you could file a bug for this work item, since it's
> pretty
> big.
>
>
https://codereview.chromium.**org/21406004/<https://codereview.chromium.org/2...
>

[achuithb, 2013-08-02 02:24:09]

On 2013/08/02 01:23:40, chrisgao wrote:
> Thanks for the suggestion!
> crbug.com/267219 was created.
> 

Thank you!

[commit-bot: I haz the power, 2013-08-02 15:22:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/21406004/45001

[commit-bot: I haz the power, 2013-08-02 19:12:43]

Change committed as 215340