Initial memory use status page

Initial memory use status page

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/cfb3f57a971801328eab20bcf265aa5f0d27e89a

[Brian Wilkerson, 2016-07-11 14:46:02]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-07-11 15:27:49]

LGTM

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/get_handler.dart (right):

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler.dart:1663: List<Type> classNames
= instances.keys.toList();
These are not names, but types.
Just in case if this is an incidental misnomer.

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/memory_use.dart (right):

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/memory_use.dart:246: if (resultData != null)
{
_recordInstance throws if resultData is null.

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/memory_use.dart:280:
instances.putIfAbsent(type, () => new HashSet(equals: identical));
Or just new HashSet.identity()

[Brian Wilkerson, 2016-07-11 17:26:36]

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/get_handler.dart (right):

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/get_handler.dart:1663: List<Type> classNames
= instances.keys.toList();
It was accidental, thanks. Done.

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/memory_use.dart (right):

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/memory_use.dart:246: if (resultData != null)
{
> _recordInstance throws if resultData is null.

I don't think that's true. It will invoke runtimeType, but that will succeed and
return `Null`.

https://codereview.chromium.org/2140583003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/memory_use.dart:280:
instances.putIfAbsent(type, () => new HashSet(equals: identical));
Done.

[Brian Wilkerson, 2016-07-11 17:27:22]

Description was changed from

==========
Initial memory use status page
==========

to

==========
Initial memory use status page

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cfb3f57a971801328eab20bcf265aa5f0d27e89a
==========

[Brian Wilkerson, 2016-07-11 17:27:24]

Committed patchset #1 (id:1) manually as
cfb3f57a971801328eab20bcf265aa5f0d27e89a (presubmit successful).