Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 2140553002: [turbofan] Lower Smi field loads to Word32 field loads. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_Comparison_Signedness
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Lower Smi field loads to Word32 field loads. If a Smi field load is truncated to Word32, we can just load the upper 32 bits on 64-bit architectures (with 32-bit Smis), which avoids the nasty shift right that we'd have to perform otherwise to untag it. R=jarin@chromium.org Committed: https://crrev.com/71becab88d590bf3c3ebf3151a7425db9b6051c1 Cr-Commit-Position: refs/heads/master@{#37630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/compiler/simplified-lowering.cc View 1 chunk +25 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-11 09:00:27 UTC) #1
Benedikt Meurer
Hey Jaro, Here's another low hanging fruit for Kraken. Please take a look. Thanks, Benedikt
4 years, 5 months ago (2016-07-11 09:01:12 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-11 09:11:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140553002/1
4 years, 5 months ago (2016-07-11 09:13:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 09:23:40 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 09:25:11 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71becab88d590bf3c3ebf3151a7425db9b6051c1
Cr-Commit-Position: refs/heads/master@{#37630}

Powered by Google App Engine
This is Rietveld 408576698