[MD Extensions] Update polymer properties ordering

[MD Extensions] Update polymer properties ordering

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1f15dd7f5a9ac5bfbdcbbf37fa740207446c185f
Cr-Commit-Position: refs/heads/master@{#405184}

[Devlin, 2016-07-12 00:02:13]

Description was changed from

==========
[MD Extensions] Update polymer properties ordering

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
==========

to

==========
[MD Extensions] Update polymer properties ordering

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2016-07-12 00:03:24]

rdevlin.cronin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Devlin, 2016-07-12 00:03:24]

As promised.

[michaelpg, 2016-07-12 00:39:38]

nice, lgtm

do settings next!!

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.js (right):

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.js:79: // Whether or not the
expanded view of the item is shown.
nit: add @private

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.js:88: data: {
public, then private

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/manager.js (right):

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/manager.js:156: addItem: function(item) {
style guide also lists public methods before private methods; up to you if you
want to change or you prefer this grouping

[Devlin, 2016-07-12 20:30:18]

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/item.js (right):

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.js:79: // Whether or not the
expanded view of the item is shown.
On 2016/07/12 00:39:37, michaelpg wrote:
> nit: add @private

Done.

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/item.js:88: data: {
On 2016/07/12 00:39:37, michaelpg wrote:
> public, then private

Done.

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/manager.js (right):

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/manager.js:156: addItem: function(item) {
On 2016/07/12 00:39:37, michaelpg wrote:
> style guide also lists public methods before private methods; up to you if you
> want to change or you prefer this grouping

I saw, but in this case, I thought the churn wasn't as worthwhile (since these
are more interesting blame targets and a bigger move).  Lemme know if you would
prefer this done (it's not a *huge* deal since there's not a lot of history here
yet, and I'm to blame for all of it), but holding off for now.

[Devlin, 2016-07-12 20:30:22]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-07-12 20:30:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2140513003/#ps20001
(title: "Michael's")

[commit-bot: I haz the power, 2016-07-12 20:34:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 21:43:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:43:37]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaelpg, 2016-07-13 00:03:07]

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/manager.js (right):

https://codereview.chromium.org/2140513003/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/manager.js:156: addItem: function(item) {
On 2016/07/12 20:30:18, Devlin wrote:
> On 2016/07/12 00:39:37, michaelpg wrote:
> > style guide also lists public methods before private methods; up to you if
you
> > want to change or you prefer this grouping
> 
> I saw, but in this case, I thought the churn wasn't as worthwhile (since these
> are more interesting blame targets and a bigger move).  Lemme know if you
would
> prefer this done (it's not a *huge* deal since there's not a lot of history
here
> yet, and I'm to blame for all of it), but holding off for now.

nah, that's fine. This grouping is logical itself anyway.

[Devlin, 2016-07-13 15:56:32]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-07-13 15:57:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:28:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 16:28:42]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 16:31:02]

Description was changed from

==========
[MD Extensions] Update polymer properties ordering

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions] Update polymer properties ordering

Update the ordering of polymer properties passed to Polymer() to match
https://www.chromium.org/developers/web-development-style-guide.

BUG=529395
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/1f15dd7f5a9ac5bfbdcbbf37fa740207446c185f
Cr-Commit-Position: refs/heads/master@{#405184}
==========

[commit-bot: I haz the power, 2016-07-13 16:31:03]

Patchset 2 (id:??) landed as
https://crrev.com/1f15dd7f5a9ac5bfbdcbbf37fa740207446c185f
Cr-Commit-Position: refs/heads/master@{#405184}