Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2140513002: Add UMAs for SharedBuffer::lock()/unlock() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/Resource.h
diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h
index 36a1f2ad5b7be1cc22836cc07b21ac6b3616eb6b..0367bf36bd4d6f93a80f0ea1edcf6f017aee5d0b 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.h
+++ b/third_party/WebKit/Source/core/fetch/Resource.h
@@ -57,6 +57,9 @@ class SharedBuffer;
class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource> {
WTF_MAKE_NONCOPYABLE(Resource);
public:
+ // |Type| enum values are used in UMAs, so do not change the values of
+ // existing |Type|. When adding a new |Type|, append it at the last and
Ilya Sherman 2016/07/12 21:23:17 nit: s/at the last/at the end
hiroshige 2016/07/15 07:47:05 Done.
+ // update |kLastResourceType|.
enum Type {
MainResource,
Image,
@@ -73,6 +76,7 @@ public:
Media, // Audio or video file requested by a HTML5 media element
Manifest
};
+ static const int kLastResourceType = Manifest + 1;
enum Status {
NotStarted,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | tools/metrics/histograms/histograms.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698