Disable MD History in Incognito windows

Disable MD History in Incognito windows

All Uber pages are disabled in Incognito, which implicitly disabled
non-Material history. However, Material history does not use Uber UI and
so was not included in the blacklist. This CL adds chrome://history to
the blacklist to explicitly disable it in Incognito windows.

BUG=596781, 624270
Committed: https://crrev.com/f057c9421a0d0a5978f93cbf13a33378cbb84a7a
Cr-Commit-Position: refs/heads/master@{#404755}

[tsergeant, 2016-07-11 04:46:28]

Description was changed from

==========
Disable MD History in Incognito windows

All Uber pages are disabled in Incognito, which implicitly disabled
non-Material history. However, Material history does not use Uber UI and
so was not included in the blacklist. This CL explicitly adds
chrome://history to the blacklist to explicitly disable it in Incognito
windows.

BUG=596781, 624270
==========

to

==========
Disable MD History in Incognito windows

All Uber pages are disabled in Incognito, which implicitly disabled
non-Material history. However, Material history does not use Uber UI and
so was not included in the blacklist. This CL adds chrome://history to
the blacklist to explicitly disable it in Incognito windows.

BUG=596781, 624270
==========

[tsergeant, 2016-07-11 04:52:46]

tsergeant@chromium.org changed reviewers:
+ msw@chromium.org

[tsergeant, 2016-07-11 04:52:46]

msw@, can you please take a look?

[msw, 2016-07-11 17:01:11]

So does this now open history in a non-incognito window or something?
What's the reasoning for disabling these pages in incognito anyway?

[tsergeant, 2016-07-11 23:41:49]

On 2016/07/11 17:01:11, msw wrote:
> So does this now open history in a non-incognito window or something?

Yes, it will open in a new tab in a non-incognito window. 

> What's the reasoning for disabling these pages in incognito anyway?

The decision to do this dates back a long way, but
https://bugs.chromium.org/p/chromium/issues/detail?id=61813 seems to indicate
it's partly due to possible profile issues, partly due to user expectations.

[msw, 2016-07-12 00:14:42]

ok, lgtm

[tsergeant, 2016-07-12 00:37:04]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-07-12 00:37:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 00:46:22]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-12 00:47:57]

Description was changed from

==========
Disable MD History in Incognito windows

All Uber pages are disabled in Incognito, which implicitly disabled
non-Material history. However, Material history does not use Uber UI and
so was not included in the blacklist. This CL adds chrome://history to
the blacklist to explicitly disable it in Incognito windows.

BUG=596781, 624270
==========

to

==========
Disable MD History in Incognito windows

All Uber pages are disabled in Incognito, which implicitly disabled
non-Material history. However, Material history does not use Uber UI and
so was not included in the blacklist. This CL adds chrome://history to
the blacklist to explicitly disable it in Incognito windows.

BUG=596781, 624270

Committed: https://crrev.com/f057c9421a0d0a5978f93cbf13a33378cbb84a7a
Cr-Commit-Position: refs/heads/master@{#404755}
==========

[commit-bot: I haz the power, 2016-07-12 00:47:58]

Patchset 1 (id:??) landed as
https://crrev.com/f057c9421a0d0a5978f93cbf13a33378cbb84a7a
Cr-Commit-Position: refs/heads/master@{#404755}