Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2140483002: DrMemory: Remove obsolete WorkerScriptController suppression (Closed)

Created:
4 years, 5 months ago by falken
Modified:
4 years, 5 months ago
Reviewers:
shimazu
CC:
bruening+watch_chromium.org, chromium-reviews, glider+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DrMemory: Remove obsolete WorkerScriptController suppression The symbol no longer appears in the codebase. BUG=403544 Committed: https://crrev.com/14c91a96fcce59cdfd51220e01ac122cc7fa0cb3 Cr-Commit-Position: refs/heads/master@{#404600}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M tools/valgrind/drmemory/suppressions_full.txt View 1 chunk +0 lines, -11 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
falken
ptal
4 years, 5 months ago (2016-07-11 03:56:49 UTC) #2
shimazu
lgtm with a comment https://codereview.chromium.org/2140483002/diff/1/tools/valgrind/drmemory/suppressions_full.txt File tools/valgrind/drmemory/suppressions_full.txt (left): https://codereview.chromium.org/2140483002/diff/1/tools/valgrind/drmemory/suppressions_full.txt#oldcode1663 tools/valgrind/drmemory/suppressions_full.txt:1663: UNINITIALIZED READ I guess this ...
4 years, 5 months ago (2016-07-11 05:08:28 UTC) #3
falken
On 2016/07/11 at 05:08:28, shimazu wrote: > lgtm with a comment > > https://codereview.chromium.org/2140483002/diff/1/tools/valgrind/drmemory/suppressions_full.txt > ...
4 years, 5 months ago (2016-07-11 05:14:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140483002/1
4 years, 5 months ago (2016-07-11 05:15:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 05:43:11 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 05:45:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14c91a96fcce59cdfd51220e01ac122cc7fa0cb3
Cr-Commit-Position: refs/heads/master@{#404600}

Powered by Google App Engine
This is Rietveld 408576698