Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2140473004: Revert of Roll src/third_party/skia/ 4c42eebc5..3ab14ca95 (3 commits). (Closed)

Created:
4 years, 5 months ago by markusheintz_
Modified:
4 years, 5 months ago
CC:
chromium-reviews, msarett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll src/third_party/skia/ 4c42eebc5..3ab14ca95 (3 commits). (patchset #1 id:1 of https://codereview.chromium.org/2136883002/ ) Reason for revert: Breaking webkit_tests see https://bugs.chromium.org/p/chromium/issues/detail?id=627025 Original issue's description: > Roll src/third_party/skia/ 4c42eebc5..3ab14ca95 (3 commits). > > https://chromium.googlesource.com/skia.git/+log/4c42eebc5551..3ab14ca950d9 > > $ git log 4c42eebc5..3ab14ca95 --date=short --no-merges --format='%ad %ae %s' > 2016-07-10 robertphillips Fix misplaced guard > 2016-07-10 reed Revert of change mapRectScaleTranslate to pass args/ret by value (patchset #1 id:1 of https://codereview.chromium.org/2137853002/ ) > 2016-07-10 reed change mapRectScaleTranslate to pass args/ret by value > > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel > TBR=msarett@google.com > > Committed: https://crrev.com/d486f3ad74364953974e3084c08fb81292170f63 > Cr-Commit-Position: refs/heads/master@{#404593} TBR=msarett@google.com,skia-deps-roller@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3790799b73028313e774fa144325825805d389d3 Cr-Commit-Position: refs/heads/master@{#404642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
markusheintz_
Created Revert of Roll src/third_party/skia/ 4c42eebc5..3ab14ca95 (3 commits).
4 years, 5 months ago (2016-07-11 12:38:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140473004/1
4 years, 5 months ago (2016-07-11 12:39:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 12:39:42 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 12:39:54 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 12:42:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3790799b73028313e774fa144325825805d389d3
Cr-Commit-Position: refs/heads/master@{#404642}

Powered by Google App Engine
This is Rietveld 408576698