Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: content/common/manifest_manager_messages.h

Issue 2140463002: Remove WebContents::HasManifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explanatory comment for manifest_url_ resetting Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/manifest_manager_messages.h
diff --git a/content/common/manifest_manager_messages.h b/content/common/manifest_manager_messages.h
index c052f27da31861961023b73c9da1f69f77aca512..ae4a2d2a632b155705cae748656049b2fecea9f6 100644
--- a/content/common/manifest_manager_messages.h
+++ b/content/common/manifest_manager_messages.h
@@ -48,24 +48,12 @@ IPC_STRUCT_TRAITS_END()
IPC_MESSAGE_ROUTED1(ManifestManagerMsg_RequestManifest,
int /* request_id */)
-// The browser process requests whether the document loaded in the associated
-// RenderFrame has a manifest link URL. The render process will respond with
-// a HasManifestResponse IPC message, along with a bool indicating the presence
-// of a manifest link, and the |request_id| that was initially given.
-IPC_MESSAGE_ROUTED1(ManifestManagerMsg_HasManifest,
- int /* request_id */)
-
// The render process' response to a RequestManifest. The |request_id| will
-// match the one that was initially received. The |manifest_url| and |manifest|
-// will be empty in case of any failure.
+// match the one that was initially received. |manifest_url| will be empty if
+// there is no manifest specified in the associated RenderFrame's document.
+// |manifest| will be empty if a manifest was specified, but could not be
+// parsed correctly.
IPC_MESSAGE_ROUTED3(ManifestManagerHostMsg_RequestManifestResponse,
int, /* request_id */
GURL, /* manifest URL */
content::Manifest /* manifest */)
-
-// The render process' response to a HasManifest. The |request_id| is the one
-// sent from the browser. The |bool| will be true if the current document has a
-// manifest link URL, and false otherwise.
-IPC_MESSAGE_ROUTED2(ManifestManagerHostMsg_HasManifestResponse,
- int, /* request_id */
- bool /* true if the document has a manifest link */)
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698