Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: content/browser/manifest/manifest_manager_host.h

Issue 2140463002: Remove WebContents::HasManifest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Explanatory comment for manifest_url_ resetting Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/manifest/manifest_browsertest.cc ('k') | content/browser/manifest/manifest_manager_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/manifest/manifest_manager_host.h
diff --git a/content/browser/manifest/manifest_manager_host.h b/content/browser/manifest/manifest_manager_host.h
index 810f525a46d170996d89483cffbe6dbfb5898ec3..ce593eccd514ad1fc8ad8f4b0ce55c38f03c9439 100644
--- a/content/browser/manifest/manifest_manager_host.h
+++ b/content/browser/manifest/manifest_manager_host.h
@@ -26,38 +26,27 @@ class ManifestManagerHost : public WebContentsObserver {
using GetManifestCallback =
base::Callback<void(const GURL&, const Manifest&)>;
- using HasManifestCallback = base::Callback<void(bool)>;
// Calls the given callback with the manifest associated with the
// given RenderFrameHost. If the frame has no manifest or if getting it failed
// the callback will have an empty manifest.
void GetManifest(RenderFrameHost*, const GetManifestCallback&);
- // Calls the given callback with a bool indicating whether or not the document
- // associated with the given RenderFrameHost has a manifest.
- void HasManifest(RenderFrameHost*, const HasManifestCallback&);
-
// WebContentsObserver
bool OnMessageReceived(const IPC::Message&, RenderFrameHost*) override;
void RenderFrameDeleted(RenderFrameHost*) override;
private:
using GetCallbackMap = IDMap<GetManifestCallback, IDMapOwnPointer>;
- using HasCallbackMap = IDMap<HasManifestCallback, IDMapOwnPointer>;
using FrameGetCallbackMap = base::hash_map<RenderFrameHost*, GetCallbackMap*>;
- using FrameHasCallbackMap = base::hash_map<RenderFrameHost*, HasCallbackMap*>;
void OnRequestManifestResponse(
RenderFrameHost*, int request_id, const GURL&, const Manifest&);
- void OnHasManifestResponse(
- RenderFrameHost*, int request_id, bool);
// Returns the CallbackMap associated with the given RenderFrameHost, or null.
GetCallbackMap* GetCallbackMapForFrame(RenderFrameHost*);
- HasCallbackMap* HasCallbackMapForFrame(RenderFrameHost*);
FrameGetCallbackMap pending_get_callbacks_;
- FrameHasCallbackMap pending_has_callbacks_;
DISALLOW_COPY_AND_ASSIGN(ManifestManagerHost);
};
« no previous file with comments | « content/browser/manifest/manifest_browsertest.cc ('k') | content/browser/manifest/manifest_manager_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698