Rename methods in CPDF_Interform.

Rename methods in CPDF_Interform.

EnableUpdateAP acutally sets s_bUpdateAP to the given parameter. So
SetUpdateAP is accurate method name.

Committed: https://pdfium.googlesource.com/pdfium/+/38506d3334fe114fb386ea9b719d432ff1760e42

[jaepark, 2016-07-13 00:49:09]

Description was changed from

==========
Rename methods in CPDF_Inteform.

EnableUpdateAP acutally sets s_bUpdateAP to the given parameter. So
SetUpdateAP is accurate method name.
==========

to

==========
Rename methods in CPDF_Interform.

EnableUpdateAP acutally sets s_bUpdateAP to the given parameter. So
SetUpdateAP is accurate method name.
==========

[jaepark, 2016-07-13 00:50:36]

jaepark@google.com changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-07-13 01:48:03]

https://codereview.chromium.org/2140423002/diff/1/core/fpdfdoc/doc_form.cpp
File core/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/2140423002/diff/1/core/fpdfdoc/doc_form.cpp#n...
core/fpdfdoc/doc_form.cpp:297: FX_BOOL CPDF_InterForm::UpdateAPEnabled() {
This one is hard to parse. I read it as "Update APEnabled" the first time
around, instead of "UpdatedAP Enabled".

Does "IsUpdateAPEnabled" seem clear?

https://codereview.chromium.org/2140423002/diff/1/core/fpdfdoc/doc_form.cpp#n...
core/fpdfdoc/doc_form.cpp:297: FX_BOOL CPDF_InterForm::UpdateAPEnabled() {
Can you add some line breaks while you are here?

[jaepark, 2016-07-13 02:02:57]

https://codereview.chromium.org/2140423002/diff/1/core/fpdfdoc/doc_form.cpp
File core/fpdfdoc/doc_form.cpp (right):

https://codereview.chromium.org/2140423002/diff/1/core/fpdfdoc/doc_form.cpp#n...
core/fpdfdoc/doc_form.cpp:297: FX_BOOL CPDF_InterForm::UpdateAPEnabled() {
On 2016/07/13 01:48:02, Lei Zhang wrote:
> This one is hard to parse. I read it as "Update APEnabled" the first time
> around, instead of "UpdatedAP Enabled".
> 
> Does "IsUpdateAPEnabled" seem clear?

Done.

https://codereview.chromium.org/2140423002/diff/1/core/fpdfdoc/doc_form.cpp#n...
core/fpdfdoc/doc_form.cpp:297: FX_BOOL CPDF_InterForm::UpdateAPEnabled() {
On 2016/07/13 01:48:02, Lei Zhang wrote:
> Can you add some line breaks while you are here?

Done.

[Lei Zhang, 2016-07-13 02:06:13]

lgtm

[jaepark, 2016-07-13 02:38:26]

The CQ bit was checked by jaepark@google.com

[commit-bot: I haz the power, 2016-07-13 02:38:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:50:54]

Description was changed from

==========
Rename methods in CPDF_Interform.

EnableUpdateAP acutally sets s_bUpdateAP to the given parameter. So
SetUpdateAP is accurate method name.
==========

to

==========
Rename methods in CPDF_Interform.

EnableUpdateAP acutally sets s_bUpdateAP to the given parameter. So
SetUpdateAP is accurate method name.

Committed:
https://pdfium.googlesource.com/pdfium/+/38506d3334fe114fb386ea9b719d432ff176...
==========

[commit-bot: I haz the power, 2016-07-13 02:50:55]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/38506d3334fe114fb386ea9b719d432ff176...