Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2140413002: Hide PaymentRequest UI spinner during CVC unmask (Closed)

Created:
4 years, 5 months ago by please use gerrit instead
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hide PaymentRequest UI spinner during CVC unmask BUG=627668 Committed: https://crrev.com/4c5190acf73987469d0744a81c75696aa66e9191 Cr-Commit-Position: refs/heads/master@{#405209}

Patch Set 1 #

Patch Set 2 : Show the processing spinner while the website is processing the payment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 2 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
please use gerrit instead
dfalcantara@, lower priority ptal. Screenshots in http://crbug.com/627668#c1.
4 years, 5 months ago (2016-07-13 00:44:14 UTC) #2
please use gerrit instead
This patch will need to be updated after http://crrev.com/2148553002 lands or vice versa.
4 years, 5 months ago (2016-07-13 00:45:08 UTC) #3
gone
Slightly worried about flickering, but it'll still be loads better than showing both, I guess. ...
4 years, 5 months ago (2016-07-13 17:19:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140413002/20001
4 years, 5 months ago (2016-07-13 17:27:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 17:34:01 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 17:34:05 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:35:11 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4c5190acf73987469d0744a81c75696aa66e9191
Cr-Commit-Position: refs/heads/master@{#405209}

Powered by Google App Engine
This is Rietveld 408576698