Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 21404002: Remove SkBlendImageFilter, and all tests. Its functionality has been subsumed by SkXfermodeImageFil… (Closed)

Created:
7 years, 4 months ago by Stephen White
Modified:
7 years, 4 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Remove SkBlendImageFilter, and all tests. Its functionality has been subsumed by SkXfermodeImageFilter. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=10482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -710 lines) Patch
D bench/BlendBench.cpp View 1 chunk +0 lines, -196 lines 0 comments Download
D gm/blend.cpp View 1 chunk +0 lines, -106 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M gyp/bench.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/effects.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D include/effects/SkBlendImageFilter.h View 1 chunk +0 lines, -51 lines 0 comments Download
src/effects/SkBlendImageFilter.cpp View 1 chunk +0 lines, -349 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Stephen White
Rob: PTAL. Thanks!
7 years, 4 months ago (2013-07-31 21:34:31 UTC) #1
robertphillips
lgtm
7 years, 4 months ago (2013-07-31 22:48:52 UTC) #2
Stephen White
7 years, 4 months ago (2013-08-01 14:59:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r10482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698