Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 2140383005: cc: Decouple LayerTreeTests from FakeOutputSurface expectations. (Closed)

Created:
4 years, 5 months ago by danakj
Modified:
4 years, 5 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@novirtualswapbuffers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Decouple LayerTreeTests from FakeOutputSurface expectations. LayerTreeTests expect the output surface on the LayerTreeHostImpl to be a FakeOutputSurface, but we will be changing it to be a TestDelegatingOutputSurface in the future, with a Display, and a FakeOutputSurface in the Display instead. This removes the LayerTreeTest::CreateFakeOutputSurface() method, and has tests override the LayerTreeTest::CreateOutputSurface() instead, storing the FakeOutputSurface* themselves as needed. This also means we don't have a null FakeOutputSurface* in pixel tests, yay. In the future, this method will become CreateDisplayOutputSurface or something, so that tests can control the surface in the Display (and all the contexts), without changing the TestDelegatingOutputSurface in the LayerTreeHostImpl. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel Committed: https://crrev.com/b175e4c8fef543c6297d7c9112f50b44d3e1e513 Cr-Commit-Position: refs/heads/master@{#405548}

Patch Set 1 #

Patch Set 2 : layertreetest-outputsurface: . #

Patch Set 3 : layertreetest-outputsurface: rebase #

Patch Set 4 : layertreetest-outputsurface: android-compile #

Patch Set 5 : layertreetest-outputsurface: more-android #

Patch Set 6 : layertreetest-outputsurface: more-more-android #

Patch Set 7 : layertreetest-outputsurface: more-more-more-android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -66 lines) Patch
M cc/layers/surface_layer_unittest.cc View 1 2 3 4 5 3 chunks +10 lines, -1 line 0 comments Download
M cc/test/layer_tree_test.h View 3 chunks +2 lines, -7 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 chunks +5 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 2 3 4 5 6 14 chunks +43 lines, -22 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 6 chunks +8 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
danakj
4 years, 5 months ago (2016-07-14 01:00:34 UTC) #2
enne (OOO)
lgtm
4 years, 5 months ago (2016-07-14 17:59:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140383005/80001
4 years, 5 months ago (2016-07-14 18:28:44 UTC) #10
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-14 18:28:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/96290)
4 years, 5 months ago (2016-07-14 18:46:09 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140383005/100001
4 years, 5 months ago (2016-07-14 18:47:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140383005/120001
4 years, 5 months ago (2016-07-14 18:50:00 UTC) #20
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-07-14 19:50:17 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 19:50:46 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 19:51:31 UTC) #25
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/b175e4c8fef543c6297d7c9112f50b44d3e1e513
Cr-Commit-Position: refs/heads/master@{#405548}

Powered by Google App Engine
This is Rietveld 408576698