Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2140383003: c/b/search/search.h|cc cleanups (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer, sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

c/b/search/search.h|cc cleanups: - Update some comments so they are closer to reality - Remove an unused enum - Slightly simplify an implementation BUG=627747 Committed: https://crrev.com/7c9bb3903da255f79ae14343768fdbe3dd63c5f4 Cr-Commit-Position: refs/heads/master@{#405479}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M chrome/browser/search/search.h View 3 chunks +8 lines, -18 lines 0 comments Download
M chrome/browser/search/search.cc View 1 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Marc Treib
4 years, 5 months ago (2016-07-13 09:49:55 UTC) #5
Marc Treib
4 years, 5 months ago (2016-07-14 11:09:25 UTC) #13
sfiera
LGTM
4 years, 5 months ago (2016-07-14 11:21:24 UTC) #14
Bernhard Bauer
Non-OWNER LGTM
4 years, 5 months ago (2016-07-14 12:38:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140383003/20001
4 years, 5 months ago (2016-07-14 12:40:45 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-14 12:45:02 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 12:46:59 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c9bb3903da255f79ae14343768fdbe3dd63c5f4
Cr-Commit-Position: refs/heads/master@{#405479}

Powered by Google App Engine
This is Rietveld 408576698