Guard some of the timeline API functions under #ifndef PRODUCT ... #endif as the windows compiler d…

Guard some of the timeline API functions under #ifndef PRODUCT ... #endif as the windows compiler does not seem to do an effective job of dead code elimination leading to unresolved references in PRODUCT mode.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/fb3baee63d7646d88c5378c33bde5e7e936d51b7

[siva, 2016-07-13 00:01:24]

asiva@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-07-13 00:13:34]

LGTM

https://codereview.chromium.org/2140383002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2140383002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:5879: DART_EXPORT int64_t Dart_TimelineGetMicros() {
I would leave this one implemented even in product mode.

[siva, 2016-07-13 00:15:15]

https://codereview.chromium.org/2140383002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/2140383002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:5879: DART_EXPORT int64_t Dart_TimelineGetMicros() {
On 2016/07/13 00:13:34, rmacnak wrote:
> I would leave this one implemented even in product mode.

Done.

[siva, 2016-07-13 00:29:50]

Description was changed from

==========
Guard some of the timeline API functions under #ifndef PRODUCT ... #endif as the
windows compiler does not seem to do an effective job of dead code elimination
leading to unresolved references in PRODUCT mode.
==========

to

==========
Guard some of the timeline API functions under #ifndef PRODUCT ... #endif as the
windows compiler does not seem to do an effective job of dead code elimination
leading to unresolved references in PRODUCT mode.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/fb3baee63d7646d88c5378c33bde5e7e936d51b7
==========

[siva, 2016-07-13 00:29:53]

Committed patchset #2 (id:20001) manually as
fb3baee63d7646d88c5378c33bde5e7e936d51b7 (presubmit successful).