Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2140363002: GN: Fix ordering of public and all dep configs (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Fix ordering of public and all dep configs. Previously GN iterated through the deps and added the all_dependent followed by the public configs for each target. But the ordering is documented to be all of the all_dependent_configs, followed by all of the public_configs. This patch brings the ordering in line with the documentation and adds a test. BUG=474000 Committed: https://crrev.com/47e6f464f5f85e3ad0b4bc21b570735e2fcfba7d Cr-Commit-Position: refs/heads/master@{#405257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -7 lines) Patch
M tools/gn/target.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gn/target.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M tools/gn/target_unittest.cc View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
brettw
4 years, 5 months ago (2016-07-12 22:46:07 UTC) #2
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-13 17:22:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140363002/1
4 years, 5 months ago (2016-07-13 19:40:57 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 20:10:54 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 20:11:01 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:12:17 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47e6f464f5f85e3ad0b4bc21b570735e2fcfba7d
Cr-Commit-Position: refs/heads/master@{#405257}

Powered by Google App Engine
This is Rietveld 408576698