Collect TokenStreams into the vm isolate snapshot instead of Scripts.

Collect TokenStreams into the vm isolate snapshot instead of Scripts.

Fixes caching-JIT and codeless app snapshots.

After the move of the compile time constant cache from the object store to individual caches on each script, we started attempting to include const objects in the vm isolate instead of the regular isolate.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/83da4db9f9f5d8d5894e603c9a10402f328f0aac

[rmacnak, 2016-07-12 22:30:01]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, turnidge@google.com

[Florian Schneider, 2016-07-12 22:36:08]

Lgtm

https://codereview.chromium.org/2140333002/diff/1/runtime/vm/clustered_snapsh...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2140333002/diff/1/runtime/vm/clustered_snapsh...
runtime/vm/clustered_snapshot.cc:4884: // Collect all the script objects and
their accompanying token stream
Update comment here as well.

[rmacnak, 2016-07-12 23:22:35]

Also renamed the visitor to avoid link-time collision between
clustered_snapshot's and compiler_stats's TokenStreamVisitor.

https://codereview.chromium.org/2140333002/diff/1/runtime/vm/clustered_snapsh...
File runtime/vm/clustered_snapshot.cc (right):

https://codereview.chromium.org/2140333002/diff/1/runtime/vm/clustered_snapsh...
runtime/vm/clustered_snapshot.cc:4884: // Collect all the script objects and
their accompanying token stream
On 2016/07/12 22:36:08, Florian Schneider wrote:
> Update comment here as well.

Done.

[rmacnak, 2016-07-12 23:25:25]

Description was changed from

==========
Collect TokenStreams into the vm isolate snapshot instead of Scripts.

Fixes caching-JIT and codeless app snapshots.

After the move of the compile time constant cache from the object store to
individual caches on each script, we started attempting to include const objects
in the vm isolate instead of the regular isolate.
==========

to

==========
Collect TokenStreams into the vm isolate snapshot instead of Scripts.

Fixes caching-JIT and codeless app snapshots.

After the move of the compile time constant cache from the object store to
individual caches on each script, we started attempting to include const objects
in the vm isolate instead of the regular isolate.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/83da4db9f9f5d8d5894e603c9a10402f328f0aac
==========

[rmacnak, 2016-07-12 23:25:27]

Committed patchset #2 (id:20001) manually as
83da4db9f9f5d8d5894e603c9a10402f328f0aac (presubmit successful).