Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2140293002: Fix Lua bugs, nit name change (Closed)

Created:
4 years, 5 months ago by fmenozzi
Modified:
4 years, 5 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M tools/lua/gradients.lua View 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
fmenozzi
- Fixed nit name change - Fixed bugs in calculating isEvenlySpaced and numHardStops that caused ...
4 years, 5 months ago (2016-07-12 19:10:25 UTC) #3
tomhudson
lgtm
4 years, 5 months ago (2016-07-12 20:23:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140293002/1
4 years, 5 months ago (2016-07-12 20:24:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/90ccfbaf2e758ef8aa5b3b4aff0ace0659e35001
4 years, 5 months ago (2016-07-12 21:55:43 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 21:55:51 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked.

Powered by Google App Engine
This is Rietveld 408576698