chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java - Issue 2140273002: Add web_manifest_url in WebappInfo.

Unified Diff: chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java

Issue 2140273002: Add web_manifest_url in WebappInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/webapk/libs/common/src/org/chromium/webapk/lib/common/WebApkConstants.java ('k') | chrome/android/webapk/shell_apk/AndroidManifest.xml » ('j') | chrome/android/webapk/shell_apk/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java

diff --git a/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java b/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java

index 5f63ae5cec0204c7c18ba5314c4f1b5a1fb7ffe8..f8aa64b37f06f3d12606badcf7ca27244866dbf0 100644

--- a/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java

+++ b/chrome/android/webapk/libs/runtime_library/src/org/chromium/webapk/lib/runtime_library/HostBrowserLauncher.java

@@ -34,6 +34,7 @@ public class HostBrowserLauncher {

private static final String META_DATA_THEME_COLOR = "themeColor";

private static final String META_DATA_BACKGROUND_COLOR = "backgroundColor";

private static final String META_DATA_ICON_URL = "iconUrl";

+ private static final String META_DATA_WEB_MANFIEST_URL = "webManifestUrl";

pkotwicz 2016/07/12 20:12:45 Nit: META_DATA_WEB_MANFIEST_URL -> META_DATA_WEB_M

Xi Han 2016/07/12 20:58:32 Done.

/**

* Key for passing app icon id in Bundle to {@link #launch()}.

@@ -83,6 +84,7 @@ public class HostBrowserLauncher {

long themeColor = getLongFromBundle(metaBundle, META_DATA_THEME_COLOR);

long backgroundColor = getLongFromBundle(metaBundle, META_DATA_BACKGROUND_COLOR);

boolean isIconGenerated = TextUtils.isEmpty(metaBundle.getString(META_DATA_ICON_URL));

+ String webManifestUrl = metaBundle.getString(META_DATA_WEB_MANFIEST_URL);

Log.v(TAG, "Url of the WebAPK: " + url);

Log.v(TAG, "WebappId of the WebAPK: " + webappId);

Log.v(TAG, "Name of the WebAPK:" + name);

@@ -106,7 +108,8 @@ public class HostBrowserLauncher {

.putExtra(WebApkConstants.EXTRA_IS_ICON_GENERATED, isIconGenerated)

.putExtra(WebApkConstants.EXTRA_WEBAPK_PACKAGE_NAME, packageName)

.putExtra(WebApkConstants.EXTRA_WEBAPK_DISPLAY_MODE, displayMode)

- .putExtra(WebApkConstants.EXTRA_WEBAPK_ORIENTATION, orientation);

+ .putExtra(WebApkConstants.EXTRA_WEBAPK_ORIENTATION, orientation)

+ .putExtra(WebApkConstants.EXTRA_WEB_MANIFEST_URL, webManifestUrl);

try {

context.startActivity(newIntent);