third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 2140263002: Early out of registerViewportLayerWithCompositor if there's no local MainFrame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2140263002: Early out of registerViewportLayerWithCompositor if there's no local MainFrame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 3dc1d8305682699a68763efa2ebe2dfcb15c50c9..ddbbd2d4f4d64d0ae6bc9ac4fe471116b7fb82cc 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -4193,7 +4193,9 @@ bool WebViewImpl::tabsToLinks() const

void WebViewImpl::registerViewportLayersWithCompositor()

{

DCHECK(m_layerTreeView);

- DCHECK(page()->deprecatedLocalMainFrame());

+ if (!page()->mainFrame() || !page()->mainFrame()->isLocalFrame())

+ return;

Document* document = page()->deprecatedLocalMainFrame()->document();

« no previous file with comments | « no previous file | no next file » | no next file with comments »