Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 214023002: Use default SkCanvas::saveLayer() flags. (Closed)

Created:
6 years, 9 months ago by f(malita)
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Use default SkCanvas::saveLayer() flags. SaveFlags are getting deprecated in Skia, and this CL removes their saveLayer-related clients. Also removing an unneeded clip() call - saveLayer() handles it internally by default these days. Due to this change, a handful of SVG tests require minor rebaselining. R=reed@google.com,senorblanco@chromium.org,schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +18 lines, -0 lines 0 comments Download
M LayoutTests/platform/linux/svg/W3C-SVG-1.1/masking-path-01-b-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/custom/absolute-sized-content-with-resources-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/custom/masking-clipping-hidpi-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-dom-height-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-dom-maskContentUnits-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-dom-width-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-dom-x-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-dom-y-attr-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-svgdom-height-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-svgdom-maskContentUnits-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-svgdom-width-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-svgdom-x-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/dynamic-updates/SVGMaskElement-svgdom-y-prop-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/transforms/text-with-mask-with-svg-transform-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/svg/zoom/page/zoom-mask-with-percentages-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/svg/custom/grayscale-gradient-mask-2-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/svg/custom/grayscale-gradient-mask-expected.png View Binary file 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 2 chunks +4 lines, -25 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
f(malita)
6 years, 9 months ago (2014-03-27 00:51:22 UTC) #1
Stephen White
Great! LGTM Some of the new baselines look like they're missing/empty, but maybe that's just ...
6 years, 9 months ago (2014-03-27 01:00:26 UTC) #2
f(malita)
On 2014/03/27 01:00:26, Stephen White wrote: > Great! LGTM > > Some of the new ...
6 years, 9 months ago (2014-03-27 01:07:50 UTC) #3
f(malita)
The CQ bit was checked by fmalita@chromium.org
6 years, 9 months ago (2014-03-27 01:21:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/214023002/1
6 years, 9 months ago (2014-03-27 01:21:43 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 01:50:27 UTC) #6
Message was sent while issue was closed.
Change committed as 170119

Powered by Google App Engine
This is Rietveld 408576698