Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 2140173004: [SPv2] FrameView::synchronizedPaint should apply root property nodes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: revised Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index e9c1059f1eb30ce1f643cb8f72b2e36ab0e03bce..f61ba0a5c88883a38b232cd9c760536b28535e89 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -40,6 +40,7 @@
#include "platform/geometry/LayoutRect.h"
#include "platform/graphics/Color.h"
#include "platform/graphics/paint/ClipPaintPropertyNode.h"
+#include "platform/graphics/paint/EffectPaintPropertyNode.h"
#include "platform/graphics/paint/TransformPaintPropertyNode.h"
#include "platform/scroll/ScrollTypes.h"
#include "platform/scroll/Scrollbar.h"
@@ -600,6 +601,15 @@ public:
void setContentClip(PassRefPtr<ClipPaintPropertyNode> contentClip) { m_contentClip = contentClip; }
ClipPaintPropertyNode* contentClip() const { return m_contentClip.get(); }
+ void setRootTransform(PassRefPtr<TransformPaintPropertyNode> rootTransform) { m_rootTransform = rootTransform; }
+ TransformPaintPropertyNode* rootTransform() const { return m_rootTransform.get(); }
+
+ void setRootClip(PassRefPtr<ClipPaintPropertyNode> rootClip) { m_rootClip = rootClip; }
+ ClipPaintPropertyNode* rootClip() const { return m_rootClip.get(); }
+
+ void setRootEffect(PassRefPtr<EffectPaintPropertyNode> rootEffect) { m_rootEffect = rootEffect; }
+ EffectPaintPropertyNode* rootEffect() const { return m_rootEffect.get(); }
+
// TODO(ojan): Merge this with IntersectionObserver once it lands.
IntRect computeVisibleArea();
@@ -910,6 +920,12 @@ private:
// TODO(trchen): This will not be needed once settings->rootLayerScrolls() is enabled.
RefPtr<ClipPaintPropertyNode> m_contentClip;
+ // These nodes represent the root nodes of each property tree.
+ // Only the root frame should create them and they will be no-op.
+ RefPtr<TransformPaintPropertyNode> m_rootTransform;
+ RefPtr<ClipPaintPropertyNode> m_rootClip;
+ RefPtr<EffectPaintPropertyNode> m_rootEffect;
+
// This is set on the local root frame view only.
DocumentLifecycle::LifecycleState m_currentUpdateLifecyclePhasesTargetState;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/FrameView.cpp » ('j') | third_party/WebKit/Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698