[SPv2] FrameView::synchronizedPaint should apply root property nodes

third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "platform/graphics/paint/GeometryMapper.h"
 #include "platform/graphics/paint/TransformPaintPropertyNode.h"
@@ skipping 126 matching lines @@
 }
 
 TEST_F(PaintPropertyTreeBuilderTest, FrameScrollingTraditional)
 {
     setBodyInnerHTML("<style> body { height: 10000px; } </style>");
 
     document().domWindow()->scrollTo(0, 100);
 
     FrameView* frameView = document().view();
     frameView->updateAllLifecyclePhases();
     EXPECT_EQ(TransformationMatrix(), frameView->preTranslation()->matrix());

[pdr., 2016/07/13 02:26:51]

Which test caused the original test to be rolled out? Can you confirm that it
passes with both patches applied?

[trchen, 2016/07/13 02:50:39]

HTMLCanvasPainterTestForSPv2.Canvas2DLayerAppearsInLayerTree
VideoPainterTestForSPv2.VideoLayerAppearsInLayerTree

Yes, verified this time. 

-    EXPECT_EQ(nullptr, frameView->preTranslation()->parent());
+    EXPECT_EQ(frameView->rootTransform(), frameView->preTranslation()->parent());
+    EXPECT_EQ(nullptr, frameView->rootTransform()->parent());
     EXPECT_EQ(TransformationMatrix().translate(0, -100), frameView->scrollTranslation()->matrix());
     EXPECT_EQ(frameView->preTranslation(), frameView->scrollTranslation()->parent());
     EXPECT_EQ(frameView->preTranslation(), frameView->contentClip()->localTransformSpace());
     EXPECT_EQ(FloatRoundedRect(0, 0, 800, 600), frameView->contentClip()->clipRect());
-    EXPECT_EQ(nullptr, frameView->contentClip()->parent());
+    EXPECT_EQ(frameView->rootClip(), frameView->contentClip()->parent());
+    EXPECT_EQ(nullptr, frameView->rootClip()->parent());

[pdr., 2016/07/13 02:26:51]

Add a basic test for effect too?

[trchen, 2016/07/13 02:50:39]

Root effect was already unconditionally created. This CL didn't change effect
tree. (Pretty sure there are unit tests that verifies effect hierarchy.)

 
     LayoutViewItem layoutViewItem = document().layoutViewItem();
     ObjectPaintProperties* layoutViewProperties = layoutViewItem.objectPaintProperties();
     EXPECT_EQ(nullptr, layoutViewProperties->scrollTranslation());
 }
 
 // TODO(trchen): Settings::rootLayerScrolls cannot be switched after main frame being created.
 // Need to set it during test setup. Besides that, the test still won't work because
 // root layer scrolling mode is not compatible with SPv2 at this moment.
 // (Duplicate display item ID for FrameView and LayoutView.)
@@ skipping 937 matching lines @@
 
     LayoutObject& rectWithTransform = *document().getElementById("rect")->layoutObject();
     ObjectPaintProperties* rectWithTransformProperties = rectWithTransform.objectPaintProperties();
     EXPECT_EQ(TransformationMatrix().translate(1, 1), rectWithTransformProperties->transform()->matrix());
 
     // Ensure there is no PaintOffset transform between the rect and the svg's transform.
     EXPECT_EQ(svgWithTransformProperties->transform(), rectWithTransformProperties->transform()->parent());
 }
 
 } // namespace blink