[SPv2] FrameView::synchronizedPaint should apply root property nodes

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 2616 matching lines @@
     forAllNonThrottledFrameViews([](FrameView& frameView) {
         frameView.lifecycle().advanceTo(DocumentLifecycle::PaintClean);
         LayoutViewItem layoutViewItem = frameView.layoutViewItem();
         if (!layoutViewItem.isNull())
             layoutViewItem.layer()->clearNeedsRepaintRecursively();
     });
 }
 
 void FrameView::synchronizedPaintRecursively(GraphicsLayer* graphicsLayer)
 {
-    if (graphicsLayer->drawsContent())
+    if (graphicsLayer->drawsContent()) {
+        // Usually this is not needed because the PaintLayer will setup the chunk properties

[pdr., 2016/07/13 02:26:51]

Can you wrap this in:
#ifndef NDEBUG

...

#endif

[trchen, 2016/07/13 02:50:39]

I'm thinking non-RLS scrollbars will need this too.

+        // altogether. However in debug builds the GraphicsLayer could paint debug background before
+        // we ever reach the PaintLayer.
+        if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {

[pdr., 2016/07/13 02:26:51]

Instead of special-casing this, is it possible to trigger a full update by
calling updatePaintProperties();?

[trchen, 2016/07/13 02:50:39]

We always have up-to-date property tree at this point so calling
updatePaintProperties() will be no-op.

This ensures none of the paint chunk property can be nullptr (which really meant
the root node).

+            PaintChunkProperties properties;
+            properties.transform = m_rootTransform;
+            properties.clip = m_rootClip;
+            properties.effect = m_rootEffect;
+            graphicsLayer->getPaintController().updateCurrentPaintChunkProperties(properties);
+        }
         graphicsLayer->paint(nullptr);
+        if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+            graphicsLayer->getPaintController().updateCurrentPaintChunkProperties(PaintChunkProperties());
+    }
 
     if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
         if (GraphicsLayer* maskLayer = graphicsLayer->maskLayer())
             synchronizedPaintRecursively(maskLayer);
         if (GraphicsLayer* contentsClippingMaskLayer = graphicsLayer->contentsClippingMaskLayer())
             synchronizedPaintRecursively(contentsClippingMaskLayer);
         if (GraphicsLayer* replicaLayer = graphicsLayer->replicaLayer())
             synchronizedPaintRecursively(replicaLayer);
     }
 
@@ skipping 1615 matching lines @@
     return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrottling);
 }
 
 LayoutBox& FrameView::boxForScrollControlPaintInvalidation() const
 {
     ASSERT(!layoutViewItem().isNull());
     return *layoutView();
 }
 
 } // namespace blink