Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2140173002:
Update histograms for TextSizeAdjust (Closed)
DescriptionUpdate histograms for TextSizeAdjust
This was missed in https://codereview.chromium.org/2100013002/
BUG=623158
Committed: https://crrev.com/7faccf11f79f1a2856e421e5a23f68c8b6677cea
Cr-Commit-Position: refs/heads/master@{#405143}
Patch Set 1 #Patch Set 2 : add comment to UseCounter.cpp #
Messages
Total messages: 21 (11 generated)
Description was changed from ========== Update histograms for TextSizeAdjust BUG=623158 ========== to ========== Update histograms for TextSizeAdjust BUG=623158 ==========
ymalik@chromium.org changed reviewers: + pdr@chromium.org
Description was changed from ========== Update histograms for TextSizeAdjust BUG=623158 ========== to ========== Update histograms for TextSizeAdjust This was missed in https://codereview.chromium.org/2100013002/ BUG=623158 ==========
On 2016/07/12 at 14:42:18, ymalik wrote: > LGTM, thanks! I wonder if we could adjust the comment in UseCounter.cpp so that it always appears in the diff in the codereview tool? Maybe something above maximumCSSSampleId that says "// Make sure update_use_counter_css.py was run which updates histograms.xml."?
On 2016/07/12 20:21:22, pdr. wrote: > On 2016/07/12 at 14:42:18, ymalik wrote: > > > > LGTM, thanks! > > I wonder if we could adjust the comment in UseCounter.cpp so that it always > appears in the diff in the codereview tool? Maybe something above > maximumCSSSampleId that says "// Make sure update_use_counter_css.py was run > which updates histograms.xml."? Yeah that would be a good idea. Done.
On 2016/07/12 at 22:25:37, ymalik wrote: > On 2016/07/12 20:21:22, pdr. wrote: > > On 2016/07/12 at 14:42:18, ymalik wrote: > > > > > > > LGTM, thanks! > > > > I wonder if we could adjust the comment in UseCounter.cpp so that it always > > appears in the diff in the codereview tool? Maybe something above > > maximumCSSSampleId that says "// Make sure update_use_counter_css.py was run > > which updates histograms.xml."? > > Yeah that would be a good idea. Done. LGTM++! Thank you
ymalik@chromium.org changed reviewers: + isherman@chromium.org
+isherman for histograms.xml
The CQ bit was checked by ymalik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by ymalik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update histograms for TextSizeAdjust This was missed in https://codereview.chromium.org/2100013002/ BUG=623158 ========== to ========== Update histograms for TextSizeAdjust This was missed in https://codereview.chromium.org/2100013002/ BUG=623158 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Update histograms for TextSizeAdjust This was missed in https://codereview.chromium.org/2100013002/ BUG=623158 ========== to ========== Update histograms for TextSizeAdjust This was missed in https://codereview.chromium.org/2100013002/ BUG=623158 Committed: https://crrev.com/7faccf11f79f1a2856e421e5a23f68c8b6677cea Cr-Commit-Position: refs/heads/master@{#405143} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7faccf11f79f1a2856e421e5a23f68c8b6677cea Cr-Commit-Position: refs/heads/master@{#405143} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
