Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2140163002: Revert of making heap verification more aggressive (Closed)

Created:
4 years, 5 months ago by Camillo Bruni
Modified:
4 years, 5 months ago
Reviewers:
Igor Sheludko, ulan
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of making heap verification more aggressive (patchset #7 id:120001 of https://codereview.chromium.org/2126613002/ ) Reason for revert: failing gc stress tests: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/7223/steps/Mjsunit/logs/stdio Original issue's description: > [runtime] making heap verification more aggressive > > - check that packed elements do not contain the_hole (with fix) > - verify argument objects with elements kind > - use JSObjectVerifiy in all JSObject "subclasses" > - change initialization order for ArrayLiteralBoilerplate to simplify verification > > BUG=v8:5188 > > Committed: https://crrev.com/599aa2e106ca8ab79f5cc489d1b93b6a26b19714 > Cr-Commit-Position: refs/heads/master@{#37680} TBR=ishell@chromium.org,ulan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5188 Committed: https://crrev.com/d234118e293d10b980a3c1fde75cd864ff3590b6 Cr-Commit-Position: refs/heads/master@{#37682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -291 lines) Patch
M src/factory.cc View 1 chunk +10 lines, -20 lines 0 comments Download
M src/heap/heap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 4 chunks +0 lines, -8 lines 0 comments Download
M src/objects-debug.cc View 14 chunks +78 lines, -236 lines 0 comments Download
M src/objects-inl.h View 5 chunks +28 lines, -6 lines 0 comments Download
M src/runtime/runtime-literals.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M src/runtime/runtime-regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-undefined-nan.js View 2 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Camillo Bruni
Created Revert of making heap verification more aggressive
4 years, 5 months ago (2016-07-12 14:04:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140163002/1
4 years, 5 months ago (2016-07-12 14:04:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 14:04:38 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 14:07:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d234118e293d10b980a3c1fde75cd864ff3590b6
Cr-Commit-Position: refs/heads/master@{#37682}

Powered by Google App Engine
This is Rietveld 408576698