Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2140133005: Remove MediaStream ended event from Blink. (Closed)

Created:
4 years, 5 months ago by Guido Urdaneta
Modified:
4 years, 5 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, haraken, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MediaStream ended event from Blink. Intent to deprecate and remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/EHy8zm0eVy0 BUG=586924 Committed: https://crrev.com/fcae1580878f40181234bebeacbe5035c9501167 Cr-Commit-Position: refs/heads/master@{#405955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -109 lines) Patch
D third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended.html View 1 chunk +0 lines, -68 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-onended-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 1 chunk +2 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStream.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamDescriptor.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Guido Urdaneta
Hi, PTAL
4 years, 5 months ago (2016-07-15 11:43:17 UTC) #9
foolip
lgtm
4 years, 5 months ago (2016-07-17 12:56:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140133005/1
4 years, 5 months ago (2016-07-17 12:56:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-17 14:35:33 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-17 14:37:04 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcae1580878f40181234bebeacbe5035c9501167
Cr-Commit-Position: refs/heads/master@{#405955}

Powered by Google App Engine
This is Rietveld 408576698