Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2140133002:
[tools/perf] Remove dead code in system_health_smoke_test.py (Closed)
|
Created:
4 years, 5 months ago by nednguyen Modified:
4 years, 5 months ago Reviewers:
petrcermak CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[tools/perf] Remove dead code in system_health_smoke_test.py
NOTRY=true
BUG=615382
Committed: https://crrev.com/4828a631a7c8914d3c175c63c78fbdcee75da9b0
Cr-Commit-Position: refs/heads/master@{#404813}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
Description was changed from ========== [tools/perf] Removed dead code in system_health_smoke_test.py BUG=615382 ========== to ========== [tools/perf] Removed dead code in system_health_smoke_test.py BUG=615382 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
Description was changed from ========== [tools/perf] Removed dead code in system_health_smoke_test.py BUG=615382 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [tools/perf] Removed dead code in system_health_smoke_test.py BUG=615382 ==========
nednguyen@google.com changed reviewers: + petrcermak@chromium.org
LGTM with s/Removed/Remove/ in the patch title and description. Thanks, Petr
Description was changed from ========== [tools/perf] Removed dead code in system_health_smoke_test.py BUG=615382 ========== to ========== [tools/perf] Remove dead code in system_health_smoke_test.py BUG=615382 ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [tools/perf] Remove dead code in system_health_smoke_test.py BUG=615382 ========== to ========== [tools/perf] Remove dead code in system_health_smoke_test.py NOTRY=true BUG=615382 ==========
The CQ bit was checked by nednguyen@google.com
On 2016/07/12 16:59:45, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) Added NOTRY because all the tests pass except linux_chromium_asan_rel_ng
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Remove dead code in system_health_smoke_test.py NOTRY=true BUG=615382 ========== to ========== [tools/perf] Remove dead code in system_health_smoke_test.py NOTRY=true BUG=615382 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Remove dead code in system_health_smoke_test.py NOTRY=true BUG=615382 ========== to ========== [tools/perf] Remove dead code in system_health_smoke_test.py NOTRY=true BUG=615382 Committed: https://crrev.com/4828a631a7c8914d3c175c63c78fbdcee75da9b0 Cr-Commit-Position: refs/heads/master@{#404813} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4828a631a7c8914d3c175c63c78fbdcee75da9b0 Cr-Commit-Position: refs/heads/master@{#404813} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
