Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2140103002: Fix a comment in the GridLayout explanation (refer to column set rather than colum). (Closed)

Created:
4 years, 5 months ago by lgarron
Modified:
4 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a comment in the GridLayout explanation (refer to column set rather than colum). BUG= Committed: https://crrev.com/ba14a633e23451662959d7e9c58ca73d07208430 Cr-Commit-Position: refs/heads/master@{#414347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/layout/grid_layout.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
lgarron
sadrul@, could you review?
4 years, 3 months ago (2016-08-25 01:29:19 UTC) #2
sadrul
lgtm
4 years, 3 months ago (2016-08-25 03:49:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140103002/1
4 years, 3 months ago (2016-08-25 03:50:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/280731)
4 years, 3 months ago (2016-08-25 04:55:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140103002/1
4 years, 3 months ago (2016-08-25 05:15:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 06:58:57 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 07:00:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba14a633e23451662959d7e9c58ca73d07208430
Cr-Commit-Position: refs/heads/master@{#414347}

Powered by Google App Engine
This is Rietveld 408576698