Issue 21401: Eliminate need for build_config.h for OS_* defines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21401: Eliminate need for build_config.h for OS_* defines. (Closed)

Created:
11 years, 10 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Eliminate need for build_config.h for OS_* defines. We instead define OS_* in the platform-specific build files.

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -13 lines)			Patch
M	build/SConscript.main	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	build/build_config.h	View	3 chunks	+16 lines, -6 lines	0 comments	Download
M	build/internal/essential.vsprops	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/mac/TestShell.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/webkit.xcodeproj/project.pbxproj	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Mark Mentovai

I don't really support this, for what it's worth.

11 years, 10 months ago (2009-02-16 23:56:23 UTC) #2

ok, abandoning