Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2140083002: chromium_tests: use correct cwd for analyze diff (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_tests/api.py
diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py
index 62df7a50e98a91a909008e39317c7e5142bbfd63..fdf44df19f674988f5f7da4b4920a1b7ec059b12 100644
--- a/scripts/slave/recipe_modules/chromium_tests/api.py
+++ b/scripts/slave/recipe_modules/chromium_tests/api.py
@@ -677,12 +677,13 @@ class ChromiumTestsApi(recipe_api.RecipeApi):
"""
patch_root = self.m.gclient.calculate_patch_root(
self.m.properties.get('patch_project'))
- affected_files = self.m.tryserver.get_files_affected_by_patch(patch_root)
- for i, path in enumerate(affected_files):
+ cwd = self._working_dir.join(patch_root) if self._working_dir else None
+ files = self.m.tryserver.get_files_affected_by_patch(patch_root, cwd=cwd)
+ for i, path in enumerate(files):
path = str(path)
assert path.startswith(relative_to)
- affected_files[i] = path[len(relative_to):]
- return affected_files
+ files[i] = path[len(relative_to):]
+ return files
def analyze(self, affected_files, test_targets, additional_compile_targets,
config_file_name, mb_mastername=None, mb_buildername=None,
« no previous file with comments | « no previous file | scripts/slave/recipes/chromium_trybot.expected/analyze_finds_invalid_target.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698