Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2140053002: Handle functions with no attached node in find_position_visitor. (Closed)

Created:
4 years, 5 months ago by sigurdm
Modified:
4 years, 4 months ago
Reviewers:
danrubel
CC:
dartino-code-reviews_googlegroups.com
Base URL:
git@github.com:dartino/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle functions with no attached node in find_position_visitor. This fixes issue #582. R=danrubel@google.com Committed: https://github.com/dartino/sdk/commit/dc80f5b84d74a1fbc06b4c7300473760d993c6c2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M pkg/dartino_compiler/lib/src/find_position_visitor.dart View 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
4 years, 5 months ago (2016-07-12 06:48:50 UTC) #2
danrubel
LGTM https://codereview.chromium.org/2140053002/diff/1/pkg/dartino_compiler/lib/src/find_position_visitor.dart File pkg/dartino_compiler/lib/src/find_position_visitor.dart (right): https://codereview.chromium.org/2140053002/diff/1/pkg/dartino_compiler/lib/src/find_position_visitor.dart#newcode71 pkg/dartino_compiler/lib/src/find_position_visitor.dart:71: if (node == null) return false; Should we ...
4 years, 5 months ago (2016-07-12 14:15:06 UTC) #3
sigurdm
https://codereview.chromium.org/2140053002/diff/1/pkg/dartino_compiler/lib/src/find_position_visitor.dart File pkg/dartino_compiler/lib/src/find_position_visitor.dart (right): https://codereview.chromium.org/2140053002/diff/1/pkg/dartino_compiler/lib/src/find_position_visitor.dart#newcode71 pkg/dartino_compiler/lib/src/find_position_visitor.dart:71: if (node == null) return false; On 2016/07/12 14:15:06, ...
4 years, 4 months ago (2016-08-10 09:05:11 UTC) #4
sigurdm
4 years, 4 months ago (2016-08-10 09:05:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dc80f5b84d74a1fbc06b4c7300473760d993c6c2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698