Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: third_party/WebKit/Source/platform/network/ResourceRequest.h

Issue 2140033002: Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/network/ResourceRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/network/ResourceRequest.h
diff --git a/third_party/WebKit/Source/platform/network/ResourceRequest.h b/third_party/WebKit/Source/platform/network/ResourceRequest.h
index ffcac5b881ecf7c51f8a66f075a0abdc5569772f..568a00063ab73c2f1044b6d50f5d94a6cf554ee0 100644
--- a/third_party/WebKit/Source/platform/network/ResourceRequest.h
+++ b/third_party/WebKit/Source/platform/network/ResourceRequest.h
@@ -73,22 +73,12 @@ public:
virtual ~ExtraData() { }
};
- ResourceRequest()
- {
- initialize(KURL());
- }
-
- ResourceRequest(const String& urlString)
- {
- initialize(KURL(ParsedURLString, urlString));
- }
-
- ResourceRequest(const KURL& url)
- {
- initialize(url);
- }
-
+ ResourceRequest();
+ ResourceRequest(const String& urlString);
dcheng 2016/07/12 05:33:11 I tried to make these explicit, but it turns out a
+ ResourceRequest(const KURL&);
explicit ResourceRequest(CrossThreadResourceRequestData*);
+ ResourceRequest(const ResourceRequest&);
+ ResourceRequest& operator=(const ResourceRequest&);
// Gets a copy of the data suitable for passing to another thread.
std::unique_ptr<CrossThreadResourceRequestData> copyData() const;
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/network/ResourceRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698