Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 214003003: HTMLMetaElement should not run script inside ::insertedInto (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
Reviewers:
tkent, abarth-chromium, ojan
CC:
blink-reviews, kenneth.christiansen, dglazkov+blink, adamk+blink_chromium.org, tkent, inferno
Visibility:
Public.

Description

HTMLMetaElement should not run script inside ::insertedInto To eventually remove the ChildNodesLazySnapshot we need to stop allowing script to run inside ::insertedInto. It's also important since even with the lazy snapshot we still keep getting security bugs down there. This starts the process of removal by switching HTMLMetaElement to use a post insertion callback. R=ojan@chromium.org,abarth@chromium.org BUG=357435 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170267

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M Source/core/html/HTMLMetaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLMetaElement-in.cpp View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
esprehn
6 years, 9 months ago (2014-03-28 01:33:06 UTC) #1
esprehn
6 years, 9 months ago (2014-03-28 01:33:17 UTC) #2
tkent
lgtm
6 years, 9 months ago (2014-03-28 01:44:27 UTC) #3
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-28 01:44:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/214003003/1
6 years, 9 months ago (2014-03-28 01:45:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 02:45:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-28 02:45:30 UTC) #7
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 9 months ago (2014-03-28 03:49:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/214003003/1
6 years, 9 months ago (2014-03-28 03:49:24 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 04:39:18 UTC) #10
Message was sent while issue was closed.
Change committed as 170267

Powered by Google App Engine
This is Rietveld 408576698