Chromium Code Reviews Chromium Code Reviews
Issue 2140023002:
Clean up player-finish-*.html tests to match W3C (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html |
| diff --git a/third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html b/third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..fe99458bbc92b982384ec84b26f67b62915d72a1 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html |
| @@ -0,0 +1,79 @@ |
| +<!DOCTYPE html> |
| +<meta charset=utf-8> |
| +<title>Tests for the finish event</title> |
| +<link rel="help" href="https://w3c.github.io/web-animations/#the-current-finished-promise"> |
| +<script src="../resources/testharness.js"></script> |
| +<script src="../resources/testharnessreport.js"></script> |
| +<script src="../imported/wpt/web-animations/testcommon.js"></script> |
| +<body> |
| +<script> |
| +'use strict'; |
| +function validateFinishEvent(t, event, animation) { |
| + t.step(function() { |
| + assert_equals(event, animation, 'Animation should be target'); |
| + assert_times_equal(event.currentTime, animation.currentTime, 'Event currentTime should be animation currentTime'); |
| + }); |
| +} |
| + |
| +async_test(function(t) { |
| + var div = createDiv(t); |
| + var animation = div.animate(null, 70.0); |
| + animation.finished.then(function(event) { |
| + t.unreached_func("Seeking to finish should not queue finished event"); |
| + }) |
| + animation.finish(); |
| + animation.currentTime = 0; |
| + animation.pause(); |
| + t.done(); |
| +}, "animation.finished doesn't run when the animation seeks to finish"); |
| + |
| +async_test(function(t) { |
| + var div = createDiv(t); |
| + var animation = div.animate(null, 70.0); |
| + animation.finished.then(function (event) { |
| + t.unreached_func("Seeking past finish should not queue finished event"); |
| + }) |
| + animation.currentTime = 80.0; |
| + animation.currentTime = 0; |
| + animation.pause(); |
| + t.done(); |
| +}, "animation.finished doesn't run when the animation seeks past finish"); |
| + |
| +async_test(function(t) { |
| + var div = createDiv(t); |
| + var animation = div.animate(null, 90.0); |
| + animation.finished.then(function(event) { |
| + validateFinishEvent(t, event, animation); |
| + t.done(); |
| + }) |
| + animation.finish(); |
| +}, "animation.finished runs when the animation completes with .finish()"); |
| + |
| +async_test(function(t) { |
| + var div = createDiv(t); |
| + var animation = div.animate(null, 100); |
| + animation.finished.then(function(event) { |
| + validateFinishEvent(t, event, animation); |
| + t.done(); |
| + }) |
| +}, "animation.finished runs when the animation completes"); |
| + |
| +async_test(function(t) { |
|
alancutter (OOO until 2018)
2016/07/13 23:41:47
This would be better as a promise_test() so that i
|
| + var animation1 = createDiv(t).animate(null, 0.05); |
| + animation1.finished.then(function(event) { |
| + validateFinishEvent(t, event, animation1); |
| + animation1.currentTime = 0; |
| + return animation1.finished; |
| + }).then(function(event) { |
| + var animation2 = createDiv(t).animate(null, 0.05); |
| + animation2.finished.then(function(event) { |
| + validateFinishEvent(t, event, animation2); |
| + animation2.play(); |
| + return animation2.finished; |
| + }) |
| + return animation2.finished; |
| + }).then(function(event) { |
|
alancutter (OOO until 2018)
2016/07/13 23:41:47
Almost. The inner then() on line 69 just needs to
|
| + t.done(); |
| + }) |
| +}, "animation.finished calls can be chained"); |
| +</script> |
