Clean up player-finish-*.html tests to match W3C

Clean up player-finish-*.html tests to match W3C

Clean up web-animations-api/player-finish-*.html tests to match W3C
standards. Part of web animations test burndown.

BUG=623437
Committed: https://crrev.com/1adf0ee89ff0fc220845bcef943e464fa114f5b3
Cr-Commit-Position: refs/heads/master@{#405409}

[sashab, 2016-07-12 03:42:30]

sashab@chromium.org changed reviewers:
+ alancutter@chromium.org

[alancutter (OOO until 2018), 2016-07-12 05:25:15]

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html
(right):

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:4:
<link rel="help"
href="https://w3c.github.io/web-animations/#the-animation-interface">
This is too non-specific, how about
https://w3c.github.io/web-animations/#the-current-finished-promise?

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:14: ];
No need for actual keyframes, you can just use null.

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:27:
animation.onfinish = function(event) {
The WPTs prefer using the finished promise.

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:46: },
"animation.onfinish() doesn't runs when the animation seeks past finish");
s/doesn't runs/doesn't run/

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:92:
var animation3 = createDiv(t).animate(keyframes, 0.05);
Two levels of chaining should be sufficient.

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:104:
t.done();
It doesn't seem correct to call t.done() multiple times.

[sashab, 2016-07-12 05:45:00]

Wooooo using .finished() meant I could get rid of those stupid booleans

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html
(right):

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:4:
<link rel="help"
href="https://w3c.github.io/web-animations/#the-animation-interface">
On 2016/07/12 at 05:25:15, alancutter wrote:
> This is too non-specific, how about
https://w3c.github.io/web-animations/#the-current-finished-promise?

Done

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:4:
<link rel="help"
href="https://w3c.github.io/web-animations/#the-animation-interface">
On 2016/07/12 at 05:25:15, alancutter wrote:
> This is too non-specific, how about
https://w3c.github.io/web-animations/#the-current-finished-promise?

Done

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:14: ];
On 2016/07/12 at 05:25:15, alancutter wrote:
> No need for actual keyframes, you can just use null.

Done :)

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:46: },
"animation.onfinish() doesn't runs when the animation seeks past finish");
On 2016/07/12 at 05:25:15, alancutter wrote:
> s/doesn't runs/doesn't run/

Done

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:92:
var animation3 = createDiv(t).animate(keyframes, 0.05);
On 2016/07/12 at 05:25:15, alancutter wrote:
> Two levels of chaining should be sufficient.

Done

https://codereview.chromium.org/2140023002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:104:
t.done();
On 2016/07/12 at 05:25:15, alancutter wrote:
> It doesn't seem correct to call t.done() multiple times.

Done

[sashab, 2016-07-12 06:13:31]

Niiiice done

[alancutter (OOO until 2018), 2016-07-13 23:41:47]

lgtm with nits.
Feel free to land as is, we can fix the rest up before upstreaming.

https://codereview.chromium.org/2140023002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html
(right):

https://codereview.chromium.org/2140023002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:61:
async_test(function(t) {
This would be better as a promise_test() so that it catches any errors thrown
outside of calls to t.step().

https://codereview.chromium.org/2140023002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/web-animations-api/animation-onfinish.html:75:
}).then(function(event) {
Almost. The inner then() on line 69 just needs to come out here.

[sashab, 2016-07-14 00:14:32]

Added TODOs for the feedback :)

[alancutter (OOO until 2018), 2016-07-14 01:08:48]

The CQ bit was checked by alancutter@chromium.org

[alancutter (OOO until 2018), 2016-07-14 01:08:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2140023002/#ps60001
(title: "Added todos for review feedback")

[commit-bot: I haz the power, 2016-07-14 01:09:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 02:41:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 02:42:48]

Description was changed from

==========
Clean up player-finish-*.html tests to match W3C

Clean up web-animations-api/player-finish-*.html tests to match W3C
standards. Part of web animations test burndown.

BUG=623437
==========

to

==========
Clean up player-finish-*.html tests to match W3C

Clean up web-animations-api/player-finish-*.html tests to match W3C
standards. Part of web animations test burndown.

BUG=623437

Committed: https://crrev.com/1adf0ee89ff0fc220845bcef943e464fa114f5b3
Cr-Commit-Position: refs/heads/master@{#405409}
==========

[commit-bot: I haz the power, 2016-07-14 02:42:49]

Patchset 4 (id:??) landed as
https://crrev.com/1adf0ee89ff0fc220845bcef943e464fa114f5b3
Cr-Commit-Position: refs/heads/master@{#405409}