Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2139983002:
DrMemory: Remove a suppression of uninitialized error (Closed)
|
Created:
4 years, 5 months ago by shimazu Modified:
4 years, 5 months ago Reviewers:
falken CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDrMemory: Remove a suppression of uninitialized error
In EmbeddedWorkerDispatcher::OnStartWorker,
start_data.pauseAfterDownloadMode used not to be initialized, but this was
already fixed at http://crrev.com/1713863002, so now we can remove the suppression.
BUG=387373
Committed: https://crrev.com/5436d4f928152bb3e79c254c8b2d2c788a8de781
Cr-Commit-Position: refs/heads/master@{#405072}
Patch Set 1 #
Messages
Total messages: 19 (9 generated)
shimazu@chromium.org changed reviewers: + falken@chromium.org
ptal
Can you point to the CL/bug where it was fixed?
Description was changed from ========== DrMemory: Remove a suppression of uninitialized error In WebEmbeddedWorkerImpl::startWorkerContext, data.pauseAfterDownloadMode used not to be initialized, but this was already fixed, so now we can remove the suppression. BUG=387373 ========== to ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed, so now we can remove the suppression. BUG=387373 ==========
Description was changed from ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed, so now we can remove the suppression. BUG=387373 ========== to ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed at http://crrev.com/1713863002, so now we can remove the suppression. BUG=387373 ==========
On 2016/07/12 02:16:37, falken wrote: > Can you point to the CL/bug where it was fixed? Done.
lgtm. I'm surprised that bug lasted that long...
The CQ bit was checked by shimazu@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
shimazu@chromium.org changed reviewers: - shimazu@google.com
The CQ bit was checked by shimazu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed at http://crrev.com/1713863002, so now we can remove the suppression. BUG=387373 ========== to ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed at http://crrev.com/1713863002, so now we can remove the suppression. BUG=387373 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed at http://crrev.com/1713863002, so now we can remove the suppression. BUG=387373 ========== to ========== DrMemory: Remove a suppression of uninitialized error In EmbeddedWorkerDispatcher::OnStartWorker, start_data.pauseAfterDownloadMode used not to be initialized, but this was already fixed at http://crrev.com/1713863002, so now we can remove the suppression. BUG=387373 Committed: https://crrev.com/5436d4f928152bb3e79c254c8b2d2c788a8de781 Cr-Commit-Position: refs/heads/master@{#405072} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/5436d4f928152bb3e79c254c8b2d2c788a8de781 Cr-Commit-Position: refs/heads/master@{#405072} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
