Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2139913003: Fix for crash found by IPC fuzzing. (Closed)

Created:
4 years, 5 months ago by Ivo-OOO until feb 6
Modified:
4 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for crash in the WebRTC event log host IPC handling code. This bug was found by the IPC fuzzer. BUG=627354 Committed: https://crrev.com/e35e001ed65a2b2d31d9026458cf7a5ee151ba7c Cr-Commit-Position: refs/heads/master@{#405076}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M content/browser/media/webrtc/webrtc_eventlog_host.cc View 2 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Ivo-OOO until feb 6
Hi Tommi, please have a look at this small CL to fix a recently introduced ...
4 years, 5 months ago (2016-07-12 13:48:25 UTC) #3
tommi (sloooow) - chröme
This looks like a band aid. Can you fix the caller?
4 years, 5 months ago (2016-07-12 13:50:46 UTC) #4
tommi (sloooow) - chröme
Thanks for the context. Lgtm since this handles ipc.
4 years, 5 months ago (2016-07-12 14:01:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139913003/1
4 years, 5 months ago (2016-07-12 14:08:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191288)
4 years, 5 months ago (2016-07-12 18:14:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139913003/1
4 years, 5 months ago (2016-07-12 18:56:45 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/191857)
4 years, 5 months ago (2016-07-13 00:56:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139913003/1
4 years, 5 months ago (2016-07-13 07:34:07 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 08:10:53 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 08:11:10 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:12:14 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e35e001ed65a2b2d31d9026458cf7a5ee151ba7c
Cr-Commit-Position: refs/heads/master@{#405076}

Powered by Google App Engine
This is Rietveld 408576698