Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2139893002: Add CURRENT lock orientation. (Closed)

Created:
4 years, 5 months ago by oshima
Modified:
4 years, 5 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CURRENT lock orientation. * This also updates the API version: The CL was rebased prior to land, which was accidentally merged with another CL that added version 12. These APIs that I added haven't implemented yet, so it should be safe to update. BUG=626445 ,b/28341028 TEST=covered by unit tests. R=rickyz@chromium.org, xiyuan@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e5b8865795165551c8b0427d07b1e3f40067663b

Patch Set 1 #

Patch Set 2 : Add CURRENT lock orientation. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -55 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 4 chunks +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 1 5 chunks +158 lines, -52 lines 0 comments Download
M components/arc/common/app.mojom View 4 chunks +4 lines, -3 lines 1 comment Download

Messages

Total messages: 20 (10 generated)
oshima
rickyz@ -> app.mojom xiyuan@ -> the rest.
4 years, 5 months ago (2016-07-12 01:38:06 UTC) #4
oshima
https://codereview.chromium.org/2139893002/diff/20001/components/arc/common/app.mojom File components/arc/common/app.mojom (right): https://codereview.chromium.org/2139893002/diff/20001/components/arc/common/app.mojom#newcode5 components/arc/common/app.mojom:5: // Next MinVersion: 13 I missed this when I ...
4 years, 5 months ago (2016-07-12 01:41:21 UTC) #5
rickyz (no longer on Chrome)
mojom lgtm
4 years, 5 months ago (2016-07-12 03:16:16 UTC) #6
xiyuan
lgtm
4 years, 5 months ago (2016-07-12 16:07:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139893002/20001
4 years, 5 months ago (2016-07-12 17:15:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/261164)
4 years, 5 months ago (2016-07-12 18:51:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139893002/20001
4 years, 5 months ago (2016-07-12 20:04:21 UTC) #13
oshima
On 2016/07/12 20:04:21, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-12 22:35:58 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e5b8865795165551c8b0427d07b1e3f40067663b Cr-Commit-Position: refs/heads/master@{#404853}
4 years, 5 months ago (2016-07-12 23:00:02 UTC) #16
oshima
4 years, 5 months ago (2016-07-12 23:00:57 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e5b8865795165551c8b0427d07b1e3f40067663b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698