Now correctly tracks the case where the default browser prompt is ignored.

Now correctly tracks the case where the default browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.

Committed: https://crrev.com/29c2239ba264381a4e87d22af15f5fc442d36a40
Cr-Commit-Position: refs/heads/master@{#404914}

[Patrick Monette, 2016-07-11 19:53:21]

Patchset #1 (id:1) has been deleted

[Patrick Monette, 2016-07-11 19:54:59]

Description was changed from

==========
Now correctly tracks the Case Where the default Browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.
==========

to

==========
Now correctly tracks the case where the default browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.
==========

[Patrick Monette, 2016-07-11 21:27:56]

pmonette@chromium.org changed reviewers:
+ msw@chromium.org

[Patrick Monette, 2016-07-11 21:27:57]

PTAL

[msw, 2016-07-11 22:22:35]

lgtm with a nit

https://codereview.chromium.org/2139753002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2139753002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:70383: +  <int value="3"
label="Dismiss">The user explicitly closed the infobar.</int>
nit: keep line breaking consistent with other values.

[Patrick Monette, 2016-07-12 18:04:34]

Thanks!

https://codereview.chromium.org/2139753002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2139753002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:70383: +  <int value="3"
label="Dismiss">The user explicitly closed the infobar.</int>
On 2016/07/11 22:22:35, msw wrote:
> nit: keep line breaking consistent with other values.

I would prefer that too but that's what the formatter wanted.

[Patrick Monette, 2016-07-12 18:04:38]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:06:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 18:24:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 18:24:22]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Patrick Monette, 2016-07-12 18:27:59]

pmonette@chromium.org changed reviewers:
+ rkaplow@chromium.org

[Patrick Monette, 2016-07-12 18:28:00]

rkaplow@ PTAL

[rkaplow, 2016-07-12 21:03:17]

lgtm

[Patrick Monette, 2016-07-12 21:07:52]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2016-07-12 21:10:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:29:21]

Description was changed from

==========
Now correctly tracks the case where the default browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.
==========

to

==========
Now correctly tracks the case where the default browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.
==========

[commit-bot: I haz the power, 2016-07-13 02:29:21]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-07-13 02:29:27]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 02:31:52]

Description was changed from

==========
Now correctly tracks the case where the default browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.
==========

to

==========
Now correctly tracks the case where the default browser prompt is ignored.

Turns out IGNORE_INFO_BAR was misleading (Meant dismissed) and there was no
metric for no interaction with the infobar.

Committed: https://crrev.com/29c2239ba264381a4e87d22af15f5fc442d36a40
Cr-Commit-Position: refs/heads/master@{#404914}
==========

[commit-bot: I haz the power, 2016-07-13 02:31:54]

Patchset 1 (id:??) landed as
https://crrev.com/29c2239ba264381a4e87d22af15f5fc442d36a40
Cr-Commit-Position: refs/heads/master@{#404914}