Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2139733003: [turbofan] Strength reduction for Int32MulWithOverflow. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@2101123005
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Strength reduction for Int32MulWithOverflow. Add simple strength reduction for Int32MulWithOverflow to the MachineOperatorReducer. R=mvstanton@chromium.org Committed: https://crrev.com/d9cb130d0b2f8c45db1871edd905e95f53484cd2 Cr-Commit-Position: refs/heads/master@{#37751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -5 lines) Patch
M src/compiler/machine-operator-reducer.cc View 3 chunks +36 lines, -4 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +126 lines, -1 line 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-12 18:29:04 UTC) #1
Benedikt Meurer
Hey Michael, Here's a simple addendum to your Int32MulWithOverflow work. Please take a look. Thanks, ...
4 years, 5 months ago (2016-07-12 18:29:43 UTC) #4
mvstanton
LGTM, once first patchset is gelandet.
4 years, 5 months ago (2016-07-13 10:43:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139733003/1
4 years, 5 months ago (2016-07-14 09:03:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 09:23:52 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 09:23:54 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 09:25:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9cb130d0b2f8c45db1871edd905e95f53484cd2
Cr-Commit-Position: refs/heads/master@{#37751}

Powered by Google App Engine
This is Rietveld 408576698