Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2139613002: [debug] use handle list instead of fixed array for temporary storage. (Closed)

Created:
4 years, 5 months ago by Yang
Modified:
4 years, 5 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] use handle list instead of fixed array for temporary storage. R=jgruber@chromium.org Committed: https://crrev.com/02130bfb990b6ef7cac83ff351c6b7cfe96ce601 Cr-Commit-Position: refs/heads/master@{#37666}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M src/runtime/runtime-debug.cc View 1 4 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
4 years, 5 months ago (2016-07-11 13:05:41 UTC) #1
jgruber
lgtm https://codereview.chromium.org/2139613002/diff/1/src/runtime/runtime-debug.cc File src/runtime/runtime-debug.cc (right): https://codereview.chromium.org/2139613002/diff/1/src/runtime/runtime-debug.cc#newcode615 src/runtime/runtime-debug.cc:615: List<Handle<Object> > locals; Nit: We could use C++11 ...
4 years, 5 months ago (2016-07-11 13:59:48 UTC) #2
Yang
On 2016/07/11 13:59:48, jgruber wrote: > lgtm > > https://codereview.chromium.org/2139613002/diff/1/src/runtime/runtime-debug.cc > File src/runtime/runtime-debug.cc (right): > ...
4 years, 5 months ago (2016-07-12 07:13:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139613002/20001
4 years, 5 months ago (2016-07-12 07:16:24 UTC) #6
Yang
On 2016/07/12 07:13:53, Yang wrote: > On 2016/07/11 13:59:48, jgruber wrote: > > lgtm > ...
4 years, 5 months ago (2016-07-12 07:16:37 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-12 07:41:46 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 07:44:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02130bfb990b6ef7cac83ff351c6b7cfe96ce601
Cr-Commit-Position: refs/heads/master@{#37666}

Powered by Google App Engine
This is Rietveld 408576698