[Material][Mac] Change the "Low Severity" App Menu Icon Color to Green

[Material][Mac] Update App Menu Icons and Colors

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775
Committed: https://crrev.com/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96
Cr-Commit-Position: refs/heads/master@{#405532}

[spqchan, 2016-07-11 22:57:07]

spqchan@chromium.org changed reviewers:
+ shrike@chromium.org

[spqchan, 2016-07-11 22:57:07]

PTAL

Are these the correct color?

[spqchan, 2016-07-12 00:11:12]

On 2016/07/11 22:57:07, spqchan wrote:
> PTAL
> 
> Are these the correct color?

Actually sorry, hold this CL. I'll going to combine it with the Material App
Menu icons

[spqchan, 2016-07-12 00:41:24]

Description was changed from

==========
[Material][Mac] Change the "Low Severity" App Menu Icon Color to Green

BUG=624643
==========

to

==========
[Material][Mac] Update App Menu Icons and Colors

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775
==========

[spqchan, 2016-07-12 00:42:46]

On 2016/07/12 00:11:12, spqchan wrote:
> On 2016/07/11 22:57:07, spqchan wrote:
> > PTAL
> > 
> > Are these the correct color?
> 
> Actually sorry, hold this CL. I'll going to combine it with the Material App
> Menu icons

PTAL

I updated the App Menu icons to what's showing up on Windows.
I'm able to test the "normal" and "update" browser icons, but not "global error"
or "incompatibility warning"
Is there are good way for me to test that? Thanks!

[shrike, 2016-07-12 23:29:50]

On 2016/07/12 00:42:46, spqchan wrote:
> I updated the App Menu icons to what's showing up on Windows.
> I'm able to test the "normal" and "update" browser icons, but not "global
error"
> or "incompatibility warning"
> Is there are good way for me to test that? Thanks!

I don't know if there's a way to test that via a command line flag, but you can
at least force vectorIconId to return the vector for those states.

This looks good. Two things I noticed: first, if you run with the
--simulate-upgrade state you get the round green icon, but if you click the
button the menu shows a square green icon. Seems like those two icons should
match?

Second, while I had the menu visible the update state switched to yellow/orange.
The button icon changed to the yellow/orange color, but the menu icon remained
green.

[spqchan, 2016-07-13 19:03:17]

On 2016/07/12 23:29:50, shrike wrote:
> On 2016/07/12 00:42:46, spqchan wrote:
> > I updated the App Menu icons to what's showing up on Windows.
> > I'm able to test the "normal" and "update" browser icons, but not "global
> error"
> > or "incompatibility warning"
> > Is there are good way for me to test that? Thanks!
> 
> I don't know if there's a way to test that via a command line flag, but you
can
> at least force vectorIconId to return the vector for those states.
> 
> This looks good. Two things I noticed: first, if you run with the
> --simulate-upgrade state you get the round green icon, but if you click the
> button the menu shows a square green icon. Seems like those two icons should
> match?
> 
> Second, while I had the menu visible the update state switched to
yellow/orange.
> The button icon changed to the yellow/orange color, but the menu icon remained
> green.

1) Fyi, this is the case for Windows too. I'll bring it up in the thread to see
if they want it to be round in the menu
2) This is a problem on all platforms. I'll file a bug

[spqchan, 2016-07-13 19:10:36]

On 2016/07/13 19:03:17, spqchan wrote:
> On 2016/07/12 23:29:50, shrike wrote:
> > On 2016/07/12 00:42:46, spqchan wrote:
> > > I updated the App Menu icons to what's showing up on Windows.
> > > I'm able to test the "normal" and "update" browser icons, but not "global
> > error"
> > > or "incompatibility warning"
> > > Is there are good way for me to test that? Thanks!
> > 
> > I don't know if there's a way to test that via a command line flag, but you
> can
> > at least force vectorIconId to return the vector for those states.
> > 
> > This looks good. Two things I noticed: first, if you run with the
> > --simulate-upgrade state you get the round green icon, but if you click the
> > button the menu shows a square green icon. Seems like those two icons should
> > match?
> > 
> > Second, while I had the menu visible the update state switched to
> yellow/orange.
> > The button icon changed to the yellow/orange color, but the menu icon
remained
> > green.
> 
> 1) Fyi, this is the case for Windows too. I'll bring it up in the thread to
see
> if they want it to be round in the menu
> 2) This is a problem on all platforms. I'll file a bug

1) Brought up the question in crbug.com/84342
2) Created crbug.com/627933

[spqchan, 2016-07-13 20:47:40]

On 2016/07/13 19:10:36, spqchan wrote:
> On 2016/07/13 19:03:17, spqchan wrote:
> > On 2016/07/12 23:29:50, shrike wrote:
> > > On 2016/07/12 00:42:46, spqchan wrote:
> > > > I updated the App Menu icons to what's showing up on Windows.
> > > > I'm able to test the "normal" and "update" browser icons, but not
"global
> > > error"
> > > > or "incompatibility warning"
> > > > Is there are good way for me to test that? Thanks!
> > > 
> > > I don't know if there's a way to test that via a command line flag, but
you
> > can
> > > at least force vectorIconId to return the vector for those states.
> > > 
> > > This looks good. Two things I noticed: first, if you run with the
> > > --simulate-upgrade state you get the round green icon, but if you click
the
> > > button the menu shows a square green icon. Seems like those two icons
should
> > > match?
> > > 
> > > Second, while I had the menu visible the update state switched to
> > yellow/orange.
> > > The button icon changed to the yellow/orange color, but the menu icon
> remained
> > > green.
> > 
> > 1) Fyi, this is the case for Windows too. I'll bring it up in the thread to
> see
> > if they want it to be round in the menu
> > 2) This is a problem on all platforms. I'll file a bug
> 
> 1) Brought up the question in crbug.com/84342
> 2) Created crbug.com/627933

1) Fix for it just landed:
https://bugs.chromium.org/p/chromium/issues/detail?id=626915
I'm going to rebase

[spqchan, 2016-07-13 22:56:16]

Rebased. PTAL

[shrike, 2016-07-13 23:24:14]

Thanks for following up on the bugs.

lgtm

[spqchan, 2016-07-14 17:46:37]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2016-07-14 17:46:37]

Thanks!

+avi for OWNERS

[Avi (use Gerrit), 2016-07-14 18:00:26]

lgtm

[spqchan, 2016-07-14 18:07:36]

The CQ bit was checked by spqchan@chromium.org

[spqchan, 2016-07-14 18:07:44]

thanks!

[commit-bot: I haz the power, 2016-07-14 18:08:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:12:24]

Description was changed from

==========
[Material][Mac] Update App Menu Icons and Colors

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775
==========

to

==========
[Material][Mac] Update App Menu Icons and Colors

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775
==========

[commit-bot: I haz the power, 2016-07-14 19:12:25]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-14 19:12:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 19:15:21]

Description was changed from

==========
[Material][Mac] Update App Menu Icons and Colors

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775
==========

to

==========
[Material][Mac] Update App Menu Icons and Colors

Change the "Low Severity" color to Green. Update the icons to the MD
ones.

BUG=624643, 626775

Committed: https://crrev.com/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96
Cr-Commit-Position: refs/heads/master@{#405532}
==========

[commit-bot: I haz the power, 2016-07-14 19:15:22]

Patchset 5 (id:??) landed as
https://crrev.com/bf0c21d44b16d6e1a3c973ee5e94e4355ed4fe96
Cr-Commit-Position: refs/heads/master@{#405532}