third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html ('K') | « third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('j') | third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

index de5cc8f1c0b8e4a70a18ab5c56d078fe933d13c0..6f74138c93a26c52c4a8fd85c1c601e8c411a6d9 100644

--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

@@ -154,7 +154,7 @@ WebInspector.ConsoleViewMessage.prototype = {

if (consoleMessage.source === WebInspector.ConsoleMessage.MessageSource.ConsoleAPI) {

switch (consoleMessage.type) {

case WebInspector.ConsoleMessage.MessageType.Trace:

- this._messageElement = this._format(consoleMessage.parameters || ["console.trace()"]);

+ this._messageElement = this._format(consoleMessage.parameters || ["console.trace"]);

break;

case WebInspector.ConsoleMessage.MessageType.Clear:

this._messageElement = createTextNode(WebInspector.UIString("Console was cleared"));

@@ -1114,6 +1114,18 @@ WebInspector.ConsoleViewMessage.prototype = {

case WebInspector.ConsoleMessage.MessageType.Log:

typeString = "Log";

break;

+ case WebInspector.ConsoleMessage.MessageType.Debug:

+ typeString = "Debug";

+ break;

+ case WebInspector.ConsoleMessage.MessageType.Info:

+ typeString = "Info";

+ break;

+ case WebInspector.ConsoleMessage.MessageType.Error:

+ typeString = "Error";

+ break;

+ case WebInspector.ConsoleMessage.MessageType.Warning:

+ typeString = "Warning";

+ break;

case WebInspector.ConsoleMessage.MessageType.Dir:

typeString = "Dir";

break;