third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tests pass Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index b8bfceb3692986a6295e3b5cfada7f63c3928f35..e242552ab15ad01fc568bacb5d6832d22556e8af 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -116,7 +116,7 @@ public:

void reportExecutionContextCreated(InspectedContext*);

void reportExecutionContextDestroyed(InspectedContext*);

void inspect(std::unique_ptr<protocol::Runtime::RemoteObject> objectToInspect, std::unique_ptr<protocol::DictionaryValue> hints);

- void exceptionMessageAdded(V8ConsoleMessage*);

+ void messageAdded(V8ConsoleMessage*);

private:

void reportMessage(V8ConsoleMessage*, bool generatePreview);