[Turbofan] Support 128 bit moves/swaps for x64.

[Turbofan] Support 128 bit moves/swaps for x64.

LOG=N
BUG=v8:4124
Committed: https://crrev.com/56d013d48166e4df94c7a17d4bee5d87d15be3fa
Cr-Commit-Position: refs/heads/master@{#37654}

[bbudge, 2016-07-10 16:54:54]

bbudge@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-07-10 17:21:06]

https://codereview.chromium.org/2139513002/diff/1/src/compiler/x64/code-gener...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2139513002/diff/1/src/compiler/x64/code-gener...
src/compiler/x64/code-generator-x64.cc:2365: if (rep !=
MachineRepresentation::kSimd128) {
Can't we always do Movapd here?

https://codereview.chromium.org/2139513002/diff/1/src/compiler/x64/code-gener...
src/compiler/x64/code-generator-x64.cc:2378: __ movups(dst, src);
You should introduce Movups, that uses AVX instructions if available (see what
we do for Movapd).

[bbudge, 2016-07-10 22:45:22]

https://codereview.chromium.org/2139513002/diff/1/src/compiler/x64/code-gener...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2139513002/diff/1/src/compiler/x64/code-gener...
src/compiler/x64/code-generator-x64.cc:2365: if (rep !=
MachineRepresentation::kSimd128) {
On 2016/07/10 17:21:06, Benedikt Meurer wrote:
> Can't we always do Movapd here?

You're right. Replaced original code.

https://codereview.chromium.org/2139513002/diff/1/src/compiler/x64/code-gener...
src/compiler/x64/code-generator-x64.cc:2378: __ movups(dst, src);
On 2016/07/10 17:21:06, Benedikt Meurer wrote:
> You should introduce Movups, that uses AVX instructions if available (see what
> we do for Movapd).

Done.

[Benedikt Meurer, 2016-07-11 03:43:18]

Thanks. LGTM once xorps is addressed.

https://codereview.chromium.org/2139513002/diff/60001/src/compiler/x64/code-g...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2139513002/diff/60001/src/compiler/x64/code-g...
src/compiler/x64/code-generator-x64.cc:2443: __ xorps(kScratchDoubleReg, dst); 
// scratch contains src ^ dst.
Please do the same for xorps (sorry, missed this one).

[bbudge, 2016-07-11 17:52:44]

https://codereview.chromium.org/2139513002/diff/60001/src/compiler/x64/code-g...
File src/compiler/x64/code-generator-x64.cc (right):

https://codereview.chromium.org/2139513002/diff/60001/src/compiler/x64/code-g...
src/compiler/x64/code-generator-x64.cc:2443: __ xorps(kScratchDoubleReg, dst); 
// scratch contains src ^ dst.
On 2016/07/11 03:43:18, Benedikt Meurer wrote:
> Please do the same for xorps (sorry, missed this one).

Done. I noticed that there are existing references to xorps and vxorps, and that
these are invoked by special kSSE* and kAVX* opcodes. Is this a pattern we would
like to eliminate in a similar way?

[bbudge, 2016-07-11 18:08:35]

The CQ bit was checked by bbudge@chromium.org

[bbudge, 2016-07-11 18:08:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2139513002/#ps80001
(title: "Macroassembler supports xorps/vxorps.")

[commit-bot: I haz the power, 2016-07-11 18:08:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 18:18:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-11 18:18:24]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 18:22:00]

Description was changed from

==========
[Turbofan] Support 128 bit moves/swaps for x64.

LOG=N
BUG=v8:4124
==========

to

==========
[Turbofan] Support 128 bit moves/swaps for x64.

LOG=N
BUG=v8:4124

Committed: https://crrev.com/56d013d48166e4df94c7a17d4bee5d87d15be3fa
Cr-Commit-Position: refs/heads/master@{#37654}
==========

[commit-bot: I haz the power, 2016-07-11 18:22:01]

Patchset 5 (id:??) landed as
https://crrev.com/56d013d48166e4df94c7a17d4bee5d87d15be3fa
Cr-Commit-Position: refs/heads/master@{#37654}