chrome/common/metrics/proto/omnibox_event.proto - Issue 21395002: [InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/metrics/proto/omnibox_event.proto

Issue 21395002: [InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: this time actually fixing merge error correctly Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/metrics/proto/omnibox_event.proto

diff --git a/chrome/common/metrics/proto/omnibox_event.proto b/chrome/common/metrics/proto/omnibox_event.proto

index 4bd5dd10459980b8acc1a2007cac02c613b6db55..d57ee3ab30a8bfa78c8814642e601e728eb6cccb 100644

--- a/chrome/common/metrics/proto/omnibox_event.proto

+++ b/chrome/common/metrics/proto/omnibox_event.proto

@@ -84,7 +84,11 @@ message OmniboxEventProto {

INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS = 7;

// The new tab page in which this omnibox interaction first started

// with the user having focus in the fakebox.

- INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS = 8;

+ INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS = 8;

+ // The user is on a search result page that's not doing search term

+ // replacement, meaning the URL of the page should've appeared in the

+ // omnibox before the user started editing it, not the search terms.

+ SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT = 9;

}

optional PageClassification current_page_classification = 10;

« no previous file with comments | « chrome/browser/ui/uma_browsing_activity_observer.cc ('k') | no next file » | no next file with comments »