[InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea…

chrome/browser/ui/omnibox/omnibox_edit_model.cc

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index bdc292c8f8a68c89f27e61b0512d755ff3eca873..45dc8d012795eb2f6c4d0c0c4b5b6702e7d12adf 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -717,10 +717,10 @@ void OmniboxEditModel::OpenMatch(const AutocompleteMatch& match,
 
     // Track whether the destination URL sends us to a search results page
     // using the default search provider.
-    TemplateURL* default_provider =
+    bool is_search_results =

[Peter Kasting, 2013/07/31 23:56:51]

Nit: Not the best name; instead of trying to think of a good one, just inline
this into the conditional.

[rpetterson, 2013/08/05 19:46:12]

Done.

         TemplateURLServiceFactory::GetForProfile(profile_)->
-            GetDefaultSearchProvider();
-    if (default_provider && default_provider->IsSearchURL(destination_url))
+            IsSearchResultsPageFromDefaultSearchProvider(destination_url);
+    if (is_search_results)

[Peter Kasting, 2013/07/31 23:56:51]

Nit: While here: {}

[rpetterson, 2013/08/05 19:46:12]

Done.

       content::RecordAction(
           UserMetricsAction("OmniboxDestinationURLIsSearchOnDSP"));